Apply trivial spotless changes #2000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vast majority are indentation changes, with a few whitespace corrections. The POM changes are merely about the order of elements. Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just read #1909 after having been frustrated by having to revert a lot of changes after applying spotless to my own changes. This doesn't completely take care of #1909, but is very close to do so. What I did is to run spotless on the code, and then revert the changes that weren't what I considered "trivial". The rest is in this PR, I don't believe this commit will make history any more difficult to track, except perhaps to a very slight extent in
pom.xmlsince some sections have been shuffled around. It that's considered a problem, I can revert the changes topom.xmlas well.Merging this would make the repo much easier to work with when using spotless to fix your own changes., because changes to unmodified files will be minimal.
The vast majority of these changes are indentation changes, with a few whitespace corrections. The POM changes are merely about the order of elements.