-
Notifications
You must be signed in to change notification settings - Fork 22
8368754: runtime/cds/appcds/SignedJar.java log regex is too strict #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport of JDK-8368754: runtime/cds/appcds/SignedJar.java log regex is too strict. For parity with Oracle JDK. |
|
|
|
/integrate |
|
/sponsor |
|
Going to push as commit 395b4c4.
Your commit was automatically rebased without conflicts. |
|
@phohensee @rm-gh-8 Pushed as commit 395b4c4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8368754: runtime/cds/appcds/SignedJar.java log regex is too strict.
For parity with Oracle JDK. Fix allows whitespace after log tags and before the message content. Ran GHA Sanity Checks (passed), jtreg tier1 tests (passed) and related tests (passed) on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
(Passed) - make test-tier1
(Passed) - make test TEST=test/hotspot/jtreg/runtime/cds/appcds
(Passed) - make test TEST=test/hotspot/jtreg/runtime/cds/appcds/SignedJar.java JTREG="VM_OPTIONS=-verbose:class"
Results are attached.
linux-aarch64-jtreg-tier1.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
linux-x64-jtreg-tier1.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
macos-aarch64-jtreg-tier1.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
windows-x64-jtreg-tier1.log
windows-x64-specific-test.log
windows-x64-specific-2-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/47/head:pull/47$ git checkout pull/47Update a local copy of the PR:
$ git checkout pull/47$ git pull https://git.openjdk.org/jdk25u-dev.git pull/47/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 47View PR using the GUI difftool:
$ git pr show -t 47Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/47.diff
Using Webrev
Link to Webrev Comment