Merged
Conversation
Signed-off-by: sheche <sheche@microsoft.com>
|
@jperedadnr could you help to review this one? (assuming you are right person) thanks |
Collaborator
|
Thanks for the contribution, we'll have a look shortly. |
Contributor
Author
|
Hello @jperedadnr @abhinayagarwal, any chance to take a look at this PR? |
IDE/VSCode/Non-Modular/Gradle/hellofx/src/main/java/org/openjfx/FXMLController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: sheche <sheche@microsoft.com>
Contributor
Author
|
@abhinayagarwal Thanks for reviewing, I've address the comment. Please take a look when you have time, thanks! 😄 |
jperedadnr
reviewed
Jan 13, 2022
Collaborator
jperedadnr
left a comment
jperedadnr
left a comment
There was a problem hiding this comment.
Looks good overall. Tested all samples on Mac, and left a few comments.
IDE/VSCode/Modular/Gradle/hellofx/src/main/resources/org/openjfx/styles.css
Outdated
Show resolved
Hide resolved
IDE/VSCode/Non-Modular/Gradle/hellofx/src/main/resources/org/openjfx/styles.css
Outdated
Show resolved
Hide resolved
Signed-off-by: sheche <sheche@microsoft.com>
Contributor
Author
|
Thank you @jperedadnr, I've updated the PR, please take a look when you have time. |
Contributor
Author
|
Could we merge this PR now? |
Collaborator
|
@jdneo Done! |
Contributor
Author
|
Thank you @jperedadnr! Yes I'll write the document part recently and send a PR for that. |
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi JavaFX team, 👋
This PR is to add more JavaFX samples working with Visual Studio Code.
Below sections are added:
IDE/VSCode/Non-modular
IDE/VSCode/Modular
Signed-off-by: sheche sheche@microsoft.com