Skip to content

footnotes fix #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tiberlas wants to merge 2 commits into
base: merge-all
Choose a base branch
from
Open

footnotes fix #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68177a8
fix(footnotes): check if footnote references are in document when acc…
tiberlas Apr 16, 2025
18a3264
chore: bump version to v0.8.10.37
tiberlas Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docx/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from docx.api import Document # noqa

__version__ = '0.8.10.36'
__version__ = '0.8.10.37'
Copy link

@marcpfuller marcpfuller Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be 1.1.2

Copy link
Author

@tiberlas tiberlas Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcpfuller this is a fork of python-docx. The original project is here



# register custom Part classes with opc package reader
Expand Down
7 changes: 7 additions & 0 deletions docx/parts/document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,13 @@ def _footnotes_part(self):
part if one is not present.
"""
try:
# check if in document is used `footnoteReference`.
# If not then load the default footnote part.
# The footnote part xml remains after all the footnotes are deleted,
# so this check is to prevent loading of unused footnotes.
refs = self.document.element.xpath('//w:footnoteReference')
if len(refs) == 0:
raise KeyError
return self.part_related_by(RT.FOOTNOTES)
except KeyError:
footnotes_part = FootnotesPart.default(self.package)
Expand Down