Skip to content

Improve radial crossing checks in SphericalMesh and CylindricalMesh #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulromano merged 2 commits into from
Feb 13, 2026
Merged

Improve radial crossing checks in SphericalMesh and CylindricalMesh #3792

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c78ff1
improve checking r crossing
GuySten Feb 10, 2026
c5a6921
Replace xt::isclose and improve comments
paulromano Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/mesh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1893,18 +1893,19 @@ double CylindricalMesh::find_r_crossing(
const double inv_denominator = 1.0 / denominator;

const double p = (u.x * r.x + u.y * r.y) * inv_denominator;
double c = r.x * r.x + r.y * r.y - r0 * r0;
double D = p * p - c * inv_denominator;
double R = std::sqrt(r.x * r.x + r.y * r.y);
double D = p * p - (R - r0) * (R + r0) * inv_denominator;

if (D < 0.0)
return INFTY;

D = std::sqrt(D);

// the solution -p - D is always smaller as -p + D : Check this one first
if (std::abs(c) <= RADIAL_MESH_TOL)
// Particle is already on the shell surface; avoid spurious crossing
if (std::abs(R - r0) <= RADIAL_MESH_TOL * (1.0 + std::abs(r0)))
return INFTY;

// Check -p - D first because it is always smaller as -p + D
if (-p - D > l)
return -p - D;
if (-p + D > l)
Expand Down Expand Up @@ -2178,15 +2179,16 @@ double SphericalMesh::find_r_crossing(
if (r0 == 0.0)
return INFTY;
const double p = r.dot(u);
double c = r.dot(r) - r0 * r0;
double D = p * p - c;
double R = r.norm();
double D = p * p - (R - r0) * (R + r0);

if (std::abs(c) <= RADIAL_MESH_TOL)
// Particle is already on the shell surface; avoid spurious crossing
if (std::abs(R - r0) <= RADIAL_MESH_TOL * (1.0 + std::abs(r0)))
return INFTY;

if (D >= 0.0) {
D = std::sqrt(D);
// the solution -p - D is always smaller as -p + D : Check this one first
// Check -p - D first because it is always smaller as -p + D
if (-p - D > l)
return -p - D;
if (-p + D > l)
Expand Down
Loading