Fix virtual surface crossing#3934
Open
GuySten wants to merge 2 commits intoopenmc-dev:developfrom
Open
Conversation
04f48e9 to
e406ce9
Compare
e406ce9 to
c0d1ce4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when using complex cells openmc sometimes decide that a particle cross surface that is not on the boundary of the complex cell.
In the illustration below a particle in cell 2 cross a surface and still stays in cell 2 (a virtual crossing).
This PR fix that behavior by adding another check in complex cells that after the surface crossing the particle should be outside the cell.
Fixes #3924
Checklist
I have made corresponding changes to the documentation (if applicable)