Merged
Conversation
Member
Author
|
Please let me know when the test server is working, so I can actually test it out :) |
* add local changes * skis minio url for sparse arff * Update .htaccess * cleanup * fix in data fork * fix for CORS * minio_url to parquet_url rename * ES update Co-authored-by: root <root@openml.org> Co-authored-by: joaquinvanschoren <joaquin.vanschoren@gmail.com>
* add local changes * skis minio url for sparse arff * Update .htaccess * cleanup * fix in data fork * fix for CORS * minio_url to parquet_url rename * ES update * set htaccess back to development state (?) * Revert "set htaccess back to development state (?)" This reverts commit 9181f73. Co-authored-by: root <root@openml.org> Co-authored-by: joaquinvanschoren <joaquin.vanschoren@gmail.com>
* add local changes * skis minio url for sparse arff * Update .htaccess * cleanup * fix in data fork * fix for CORS * minio_url to parquet_url rename * ES update * set htaccess back to development state (?) * Revert "set htaccess back to development state (?)" This reverts commit 9181f73. Co-authored-by: root <root@openml.org> Co-authored-by: joaquinvanschoren <joaquin.vanschoren@gmail.com>
* add local changes * skis minio url for sparse arff * Update .htaccess * cleanup * fix in data fork * fix for CORS * minio_url to parquet_url rename * ES update * set htaccess back to development state (?) * Revert "set htaccess back to development state (?)" This reverts commit 9181f73. Co-authored-by: root <root@openml.org> Co-authored-by: joaquinvanschoren <joaquin.vanschoren@gmail.com>
* add local changes * skis minio url for sparse arff * Update .htaccess * cleanup * fix in data fork * fix for CORS * merging Api_data * merging ES * updated PHP and ES * minio_url to parquet_url rename * ES update * set htaccess back to development state (?) * Revert "set htaccess back to development state (?)" This reverts commit 9181f73. Co-authored-by: root <root@openml.org> Co-authored-by: joaquinvanschoren <joaquin.vanschoren@gmail.com> Co-authored-by: root <root@openml.test.tue.nl>
* add local changes * skis minio url for sparse arff * Update .htaccess * cleanup * fix in data fork * fix for CORS * merging Api_data * merging ES * updated PHP and ES * minio_url to parquet_url rename * ES update * set htaccess back to development state (?) * Revert "set htaccess back to development state (?)" This reverts commit 9181f73. * Develop with changes (#1172) * merging Api_data * merging ES * updated PHP and ES Co-authored-by: root <root@openml.test.tue.nl> * Revert "Develop with changes (#1172)" (#1173) This reverts commit 031dd12. * added active testing (#1183) * extends eval engine to work with additional task type active learning (#1184) * extends eval engine to work with additional task type active learning * Update openml_OS/controllers/Api_splits.php thanks for this catch! GitHub should get a Grammerly plugin Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl> --------- Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl> * Update README.md * Add qa tasktype (#1193) * adds records * bugfix * updated file * update record * update record * adds text tasks * extended with task * typo fix * adds splits option * task answers * fix dataset field * adds default task to test server reinstantiation (#1195) * Point .pq files to datasets bucket * Update to dataset description in test server, remove old minio_url field --------- Co-authored-by: root <root@openml.org> Co-authored-by: joaquinvanschoren <joaquin.vanschoren@gmail.com> Co-authored-by: root <root@openml.test.tue.nl> Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl> Co-authored-by: Jos van der Velde <j.d.v.d.velde@tue.nl>
PGijsbers
reviewed
Jan 9, 2024
Contributor
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
Mostly looks fine, but I left a few comments. I think only the first is crucial (about the index).
Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
PGijsbers
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds functions for adding description (ontology) to features