-
-
Notifications
You must be signed in to change notification settings - Fork 215
[MNT] Dockerized tests for CI runs using localhost #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
satvshr
wants to merge
69
commits into
openml:main
Choose a base branch
from
satvshr:i1614
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
83e1531
Use the correct path to the cache directory for the task
PGijsbers f90036d
Push configuration of test server URL exclusively to config.py
PGijsbers 3a257ab
Update the test to use a dataset which does not have a parquet file
PGijsbers 3b79017
Replace hard-coded cache directory by configured one
PGijsbers f524d75
Update test to use dataset file that is already in cache
PGijsbers 7ef12c2
Windows test
satvshr a5601e3
relax assumptions on local file structure
PGijsbers d862be2
Do not use static cache directory
PGijsbers 16699e6
Update expected number to match initial server state
PGijsbers 7c14c68
bug fixing
satvshr 78b2038
merge main
satvshr 16ceeaa
remove db refresh every test
satvshr 015acf4
bug fixing
satvshr 937fc77
bug fixing
satvshr 30972f8
bug fixing
satvshr 775dcf7
Add symlink to regular test cache directory
PGijsbers 319cb35
Skip test for 1.8 since expected results differ too much
PGijsbers a680ebe
Simplify path to static cache directory
PGijsbers b161b3b
Update symbolic link to be relative
PGijsbers 0b989d1
Fix typo
PGijsbers 892ea6c
trying ot fix multiple threads issue
satvshr ae3befb
removed test file
satvshr 5f396a0
removed unnecessary code (?)
satvshr 8a319cd
Trigger Build
satvshr 4ba4239
Clean up code
satvshr 0292404
comment fixing
satvshr a7b5d76
attempted bug fixing
satvshr 9b0f3d7
attempted bug fixing
satvshr 630f240
attempted bug fixing
satvshr c61d410
attempted bug fixing reverts
satvshr 1ab42b7
disabling parallel runs
satvshr 06405c8
disabling parallel runs
satvshr e22b7ca
disabling windows CI
satvshr 1b00a7f
removed docker from pytest default
satvshr cc6e673
change mysql port
satvshr c1bf558
Change order of ci flow
satvshr 1a794fe
CI testing
satvshr dbe7782
CI testing
satvshr d8be5f1
CI testing
satvshr b204845
CI testing
satvshr 54725fa
Windows CI bugfixing
satvshr abc44a5
merging 2 branches
satvshr b034687
merging 2 branches
satvshr b8826f5
merging 2 branches
satvshr 445cbe8
merging 2 branches
satvshr 295ef93
curl to verify server is running
satvshr 488f409
path fix
satvshr 93d7409
Merge branch 'update-tests-for-local' into i1614
satvshr 45e7257
run all test server tests
satvshr 7fcf039
fix 'Cleanup Docker setup'
satvshr 37cfb2e
skipping windows given docker binaries do not match
satvshr 9290010
testing out locally
satvshr bbfa193
replacing with 8080
satvshr 4531cbc
test
satvshr d90615a
test
satvshr 9b12d6f
test
satvshr 45d3423
test
satvshr 16f22b1
test
satvshr dd2ce68
test
satvshr ebeccea
test
satvshr a0ac6b9
test
satvshr 439e683
test
satvshr f87051b
test
satvshr 4077a56
test
satvshr fad1ee7
test
satvshr 4086730
test
satvshr fecebbc
windows fix?
satvshr 4845a1e
windows fix?
satvshr a247050
windows fix?
satvshr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add env var |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -277,7 +277,7 @@ def with_server(request): | |
| openml.config.apikey = None | ||
| yield | ||
| return | ||
| openml.config.server = "https://test.openml.org/api/v1/xml" | ||
| openml.config.server = f"{openml.config.TEST_SERVER_URL}/api/v1/xml" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. check the env variable @pytest.fixture(autouse=True)
def with_server(request):
if os.getenv("OPENML_USE_LOCAL_SERVICES") == "true":
openml.config.TEST_SERVER_URL = "http://localhost:8080"
if "production" in request.keywords:
openml.config.server = "https://www.openml.org/api/v1/xml"
openml.config.apikey = None
yield
return
openml.config.server = f"{openml.config.TEST_SERVER_URL}/api/v1/xml"
openml.config.apikey = TestBase.user_key
yield |
||
| openml.config.apikey = TestBase.user_key | ||
| yield | ||
|
|
||
|
|
@@ -295,8 +295,8 @@ def with_test_cache(test_files_directory, request): | |
| openml.config.set_root_cache_directory(_root_cache_directory) | ||
| if tmp_cache.exists(): | ||
| shutil.rmtree(tmp_cache) | ||
|
|
||
|
|
||
|
|
||
| @pytest.fixture | ||
| def static_cache_dir(): | ||
| return Path(__file__).parent / "files" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be following steps to setup the docker services, though these should be ignored for window machines