Moved PHP docker to the PHP repository#143
Conversation
|
I think that's fine. Would also need to update the |
|
I think downgrading ES should accomplish the same thing? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=======================================
Coverage ? 91.93%
=======================================
Files ? 49
Lines ? 1823
Branches ? 144
=======================================
Hits ? 1676
Misses ? 105
Partials ? 42 ☔ View full report in Codecov by Sentry. |
|
Doesn't reproduce for me. Doesn't even reproduce locally for me right now, but you can see it in CI (it's the SKIPS for the tag). |
See openml/OpenML#1212.
For the https://github.com/openml/services/tree/feature/docker-compose, I've chosen to use elasticsearch 6.8.23 (same as production) for now.
I've updated
openml/php-rest-apidocker container to work with ES6. This is problematic for this server-api repo. A simple solution could be to createopenml/php-rest-api:es8. What do you think?