Skip to content

Conversation

@epretti
Copy link
Member

@epretti epretti commented Nov 18, 2025

ff19ipq turns out to be an incomplete and abandoned force field: see the discussion at #410. It is possible it was added to the AmberTools distribution by mistake; we added it to openmmforcefields when we were updating it to include the new force fields distributed with recent versions of AmberTools. This removes the force field file and files needed to convert it.

@epretti
Copy link
Member Author

epretti commented Nov 18, 2025

Who has access to control the merge criteria in GitHub? (@peastman @mikemhenry?) #418 has been merged in so only OpenMM 8.3.1 and 8.4.0 are being tested, but GitHub is still trying to wait for OpenMM 8.2.0 tests even though this PR was opened after that one was merged.

@peastman
Copy link
Member

I removed the obsolete checks.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.17%. Comparing base (2b42b44) to head (5f176b5).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #419   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files           5        5           
  Lines         771      771           
=======================================
  Hits          649      649           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@epretti epretti enabled auto-merge (squash) November 18, 2025 18:30
@epretti epretti requested a review from peastman November 18, 2025 18:30
@epretti epretti merged commit cbfa007 into openmm:main Nov 18, 2025
14 checks passed
@epretti epretti deleted the remove-ff19ipq branch November 18, 2025 19:11
@mikemhenry mikemhenry mentioned this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants