Update to use modularized nlp_text_splitter package.#364
Conversation
jrobble
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @hhuangMITRE)
python/AzureTranslation/tests/test_acs_translation.py line 1040 at r1 (raw file):
def test_guess_split_edge_cases(self):
Where did this test go?
hhuangMITRE
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @jrobble)
python/AzureTranslation/tests/test_acs_translation.py line 1040 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
Where did this test go?
Ah, that got left out (in addition to the wtp-advanced/basic test), I've done another check and transferred this test into detection/nlp_text_splitter/tests/test_text_splitter.py. Thanks for spotting that.
jrobble
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
Issues:
Related PRs:
This change is