Feat/wfm trigger#197
Conversation
jrobble
left a comment
jrobble
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
jrobble
left a comment
jrobble
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
a discussion (no related file):
Please update this text in the README:
# Takes the form: "<registry-host>:<registry-port>/<repository>/", where
# <repository> is usually "openmpf". Make sure to include the "/" at the end.
# Leave blank to use images on the local host or Docker Hub.
REGISTRY=
to:
# Takes the form: "<registry-host>:<registry-port>/<repository>/", where
# <repository> is usually "openmpf". Make sure to include the "/" at the end.
# Leave blank to use images on the local host.
# Use "openmpf/" to use images on Docker Hub.
REGISTRY=
brosenberg42
left a comment
brosenberg42
left a comment
There was a problem hiding this comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @jrobble)
a discussion (no related file):
Previously, jrobble (Jeff Robble) wrote…
Please update this text in the README:
# Takes the form: "<registry-host>:<registry-port>/<repository>/", where # <repository> is usually "openmpf". Make sure to include the "/" at the end. # Leave blank to use images on the local host or Docker Hub. REGISTRY=to:
# Takes the form: "<registry-host>:<registry-port>/<repository>/", where # <repository> is usually "openmpf". Make sure to include the "/" at the end. # Leave blank to use images on the local host. # Use "openmpf/" to use images on Docker Hub. REGISTRY=
Done.
jrobble
left a comment
jrobble
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
2 participants
Issues:
Related PRs:
This change is