Skip to content

Add trigger guide#171

Merged
brosenberg42 merged 8 commits into
developfrom
feat/wfm-trigger
Nov 14, 2023
Merged

Add trigger guide#171
brosenberg42 merged 8 commits into
developfrom
feat/wfm-trigger

Conversation

Copy link
Copy Markdown
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 29 of 32 files at r1, 41 of 41 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

Copy link
Copy Markdown
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

Copy link
Copy Markdown
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

Copy link
Copy Markdown
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)

a discussion (no related file):
Please remove the GetDetectionType() from the SDK docs. Also, trackType needs to be added to "Component Descriptor Reference".


Copy link
Copy Markdown
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)

Copy link
Copy Markdown
Member Author

@brosenberg42 brosenberg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 35 of 50 files reviewed, 1 unresolved discussion (waiting on @brosenberg42 and @jrobble)

a discussion (no related file):

Previously, jrobble (Jeff Robble) wrote…

Please remove the GetDetectionType() from the SDK docs. Also, trackType needs to be added to "Component Descriptor Reference".

Done.


Copy link
Copy Markdown
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)


docs/docs/Trigger-Guide.md line 188 at r7 (raw file):

that will later satisfy the trigger for stage 4.

Also, note that stages 1, 2, and 3 can all accept an optional `WHITELIST_FILE` property that can be

This section will need to be changed to "approved list" once your other PR lands. I will leave a comment on that.

@brosenberg42 brosenberg42 merged commit c523db8 into develop Nov 14, 2023
@brosenberg42 brosenberg42 deleted the feat/wfm-trigger branch November 14, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants