Add roll up guide#178
Conversation
jrobble
left a comment
There was a problem hiding this comment.
Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
docs/docs/Roll-Up-Guide.md line 6 at r1 (raw file):
# Roll Up Overview
I pushed a jrobble/document-rollup branch. Please take a look and considering merging the changes into this one.
Among other things, I provided an example of roll up in the Overview section for clarity. Also, I moved the example JSON above the field definitions to give the reader more context up front. Additionally, I provided a "COLOR" example to give a second realistic use case.
brosenberg42
left a comment
There was a problem hiding this comment.
Reviewable status: 29 of 34 files reviewed, 1 unresolved discussion (waiting on @jrobble)
docs/docs/Roll-Up-Guide.md line 6 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
I pushed a
jrobble/document-rollupbranch. Please take a look and considering merging the changes into this one.Among other things, I provided an example of roll up in the Overview section for clarity. Also, I moved the example JSON above the field definitions to give the reader more context up front. Additionally, I provided a "COLOR" example to give a second realistic use case.
Done.
jrobble
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
Issues:
Related PRs:
This change is