Add Python3.12 install instructions#195
Conversation
jrobble
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @brosenberg42)
a discussion (no related file):
Please update openmpf.github.io/docs/docs/Python-Batch-Component-API.md everywhere py38 and cp38 are mentioned.
docs/docs/Development-Environment-Guide.md line 226 at r1 (raw file):
- Run `cd ~/openmpf-projects/openmpf/trunk/workflow-manager/src/main/resources/properties/; cp mpf-private-example.properties mpf-private.properties` - Run `pip3.8 install ansible`
Do you mean to use pip3.12 here?
|
Previously, jrobble (Jeff Robble) wrote…
I tried I read that the distutils package was deprecated in Python 3.10 and removed in Python 3.12. Is that why were using Python 3.8 for the install? |
brosenberg42
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 7 files reviewed, 2 unresolved discussions (waiting on @brosenberg42 and @jrobble)
a discussion (no related file):
Previously, jrobble (Jeff Robble) wrote…
Please update
openmpf.github.io/docs/docs/Python-Batch-Component-API.mdeverywherepy38andcp38are mentioned.
Done.
docs/docs/Development-Environment-Guide.md line 226 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
I tried
python3.12 -m pip install ansibleand got:Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/usr/lib/python3/dist-packages/pip/__main__.py", line 16, in <module> from pip._internal.cli.main import main as _main # isort:skip # noqa ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/pip/_internal/cli/main.py", line 10, in <module> from pip._internal.cli.autocompletion import autocomplete File "/usr/lib/python3/dist-packages/pip/_internal/cli/autocompletion.py", line 9, in <module> from pip._internal.cli.main_parser import create_main_parser File "/usr/lib/python3/dist-packages/pip/_internal/cli/main_parser.py", line 7, in <module> from pip._internal.cli import cmdoptions File "/usr/lib/python3/dist-packages/pip/_internal/cli/cmdoptions.py", line 19, in <module> from distutils.util import strtobool ModuleNotFoundError: No module named 'distutils'I read that the distutils package was deprecated in Python 3.10 and removed in Python 3.12.
Is that why were using Python 3.8 for the install?
I am using Python 3.8 for ansible compatibility.
jrobble
left a comment
There was a problem hiding this comment.
@jrobble reviewed 1 of 5 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)
docs/docs/Development-Environment-Guide.md line 226 at r1 (raw file):
Previously, brosenberg42 wrote…
I am using Python 3.8 for ansible compatibility.
So the sudo apt install [...] python3.8-dev python3-pip python3.8-venv part is for ansible?
Do you mean compatibility with with the current format of the ansible scripts?
If so, should we create a separate task to update our Ansible scripts so that developers don't need to install Python 3.8?
Ansible 2.16 supports Python 3.12. Ansible is now on 2.19.1.
brosenberg42
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jrobble)
docs/docs/Development-Environment-Guide.md line 226 at r1 (raw file):
Do you mean compatibility with with the current format of the ansible scripts?
No. Your experiment above proved that is not the case. The failure is happening before ansible is even installed.
jrobble
left a comment
There was a problem hiding this comment.
@jrobble reviewed 5 of 5 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)
docs/docs/Development-Environment-Guide.md line 226 at r1 (raw file):
Previously, brosenberg42 wrote…
Do you mean compatibility with with the current format of the ansible scripts?
No. Your experiment above proved that is not the case. The failure is happening before ansible is even installed.
Let's revisit this as part of the Ubuntu upgrade task: openmpf/openmpf#1687
Issues:
Related PRs:
This change is