Skip to content

Add documentation for csv selectors#204

Merged
brosenberg42 merged 4 commits into
developfrom
feat/csv-selector
Dec 19, 2025
Merged

Add documentation for csv selectors#204
brosenberg42 merged 4 commits into
developfrom
feat/csv-selector

Conversation

@brosenberg42
Copy link
Copy Markdown
Member

@brosenberg42 brosenberg42 commented Dec 2, 2025

Documentation for: openmpf/openmpf#1966

Issues:


This change is Reviewable

@brosenberg42 brosenberg42 requested a review from jrobble December 2, 2025 17:01
@brosenberg42 brosenberg42 self-assigned this Dec 2, 2025
* Add TODOs.
Copy link
Copy Markdown
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrobble reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)


a discussion (no related file):
Overall, good job and great explanation of encoding issues.

I simplified some things and performed some cleanup for clarity in this branch: https://github.com/openmpf/openmpf.github.io/blob/jrobble/csv-selector/docs/docs/Media-Selectors-Guide.md

Please review and merge that into this one.

I added some TODOs in there for you. The doc was focusing heavily on JSON_PATH and needs complete CSV_COLS for clarity and simplicity. Also, I didn't like how I had to scroll all the way past the CSV_COLS stuff to find the example JSON_PATH output. I think it's better if the JSON_PATH and CSV_COLS sections are more self-contained - although I think it's fine that the "New Job Request Fields" section is common and focuses on JSON_PATH since we really don't need to explain those fields twice. It should be clear from the CSV_COLS example request JSON (that I asked you to add) how they're being used for CSV.

Copy link
Copy Markdown
Member

@jrobble jrobble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrobble reviewed 5 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42).

@brosenberg42 brosenberg42 merged commit 8acbfa1 into develop Dec 19, 2025
1 check passed
@brosenberg42 brosenberg42 deleted the feat/csv-selector branch December 19, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants