Fix NEXRAD Level2 backend compatibility with older files and VCP-0 #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses backward compatibility issues with historical NEXRAD files and special scan modes: - Fix IndexError when msg_2 metadata is missing (older builds like Build 8.0) - Add validation for corrupted MSG_5 data in VCP-0 maintenance mode files - Handle struct unpacking errors gracefully in MSG_5 elevation data - Improve metadata reading to support different NEXRAD format versions Fixes reading of files like: - s3://unidata-nexrad-level2/2006/05/19/KLOT/KLOT20060519_183423.gz - s3://unidata-nexrad-level2/2005/01/27/KLOT/KLOT20050127_154429.gz - s3://unidata-nexrad-level2/2025/11/19/KLOT/KLOT20251119_121045_V06
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 93.52% 93.50% -0.02%
==========================================
Files 27 27
Lines 5572 5587 +15
==========================================
+ Hits 5211 5224 +13
- Misses 361 363 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Based on agent review recommendations: - Replace complex inheritance mocking with unittest.mock patterns - Add parametrized test for MSG_5 elevation validation scenarios - Enhance documentation with historical NEXRAD context (Build 8.0, VCP-0) - Simplify test structure while maintaining comprehensive coverage - Add clear test descriptions for different corruption scenarios Tests now cover: - VCP-0 maintenance mode with corrupted elevation counts (40833) - Normal VCP patterns with valid elevation cuts - Empty VCP patterns - Invalid elevation counts exceeding maximum (25) Improves maintainability and follows xradar testing patterns.
…radar into nexrad-backward-compatibility
Collaborator
kmuehlbauer
approved these changes
Dec 4, 2025
Member
Author
|
Thanks @kmuehlbauer for mentioning #293, I totally forgot it. With this PR we can close both. Please let me know if something else is required. |
Collaborator
|
Thanks @aladinor! |
This was referenced Dec 9, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
history.mdThis PR addresses backward compatibility issues with the NEXRAD Level2 backend when reading historical NEXRAD files and special scan modes.
The NEXRAD backend currently fails with:
msg_2metadatamsg_2metadata with fallback to record 0number_elevation_cutsvalues (0-25) before parsingThe following publicly available files now work correctly:
s3://unidata-nexrad-level2/2006/05/19/KLOT/KLOT20060519_183423.gzs3://unidata-nexrad-level2/2005/01/27/KLOT/KLOT20050127_154429.gzs3://unidata-nexrad-level2/2025/11/19/KLOT/KLOT20251119_121045_V06