Skip to content

Conversation

@aladinor
Copy link
Member

@aladinor aladinor commented Dec 8, 2025

Add explicit compat='override' parameter to xr.merge() call in _get_subgroup function to silence FutureWarning about upcoming xarray default changes.

Add explicit compat='override' parameter to xr.merge() call in _get_subgroup
function to silence FutureWarning about upcoming xarray default changes.
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.50%. Comparing base (93c33ea) to head (bdba528).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          27       27           
  Lines        5587     5587           
=======================================
  Hits         5224     5224           
  Misses        363      363           
Flag Coverage Δ
notebooktests ?
unittests 93.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@egouden egouden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still future warnings related to merge.

@kmuehlbauer
Copy link
Collaborator

@aladinor @egouden I've pushed a fix for the remaining xr.merge in cfradial1 backend.

@kmuehlbauer kmuehlbauer enabled auto-merge (squash) December 10, 2025 14:15
@kmuehlbauer kmuehlbauer merged commit b92537e into openradar:main Dec 10, 2025
11 checks passed
@kmuehlbauer
Copy link
Collaborator

Thanks @aladinor!

@egouden
Copy link
Contributor

egouden commented Dec 10, 2025

Great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

FutureWarning: In a future version of xarray the default value for compat will change from compat='no_conflicts' to compat='override'

3 participants