Skip to content

Ignore java.util.Iterator in NoGuavaSetsNewHashSet recipe #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 1 commit into from
Oct 28, 2025
Merged

Ignore java.util.Iterator in NoGuavaSetsNewHashSet recipe #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/openrewrite/java/migrate/guava/NoGuavaSetsNewHashSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx)
.build()
.apply(getCursor(), method.getCoordinates().replace(), method.getArguments().get(0));
}
// Skip Iterable-only cases to avoid generating broken code
if (TypeUtils.isAssignableTo("java.lang.Iterable", method.getArguments().get(0).getType())) {
// Skip Iterable-only and Iterator-only cases to avoid generating broken code
if (TypeUtils.isAssignableTo("java.lang.Iterable", method.getArguments().get(0).getType()) || TypeUtils.isAssignableTo("java.util.Iterator", method.getArguments().get(0).getType())) {
return method;
}
}
Expand Down
22 changes: 22 additions & 0 deletions src/test/java/org/openrewrite/java/migrate/guava/NoGuavaSetsNewHashSetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,28 @@ void test() {
);
}

@Test
void setsNewHashSetWithIteratorsFilter() {
//language=java
rewriteRun(
java(
"""
import java.util.Collection;
import java.util.Iterator;

import com.google.common.collect.Iterators;
import com.google.common.collect.Sets;

class Test {
public Collection<String> collectExistingRepresentations(Iterator<Object> iterator) {
return Sets.newHashSet(Iterators.filter(iterator, String.class));
}
}
"""
)
);
}

@Test
void setsNewHashSetWithCustomIterable() {
//language=java
Expand Down