Fix NPE in NestedEnumsAreNotStatic (issue #796) #802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aman Gautam <amangautam2128@gmail.com>
timtebeek
reviewed
Jan 5, 2026
Comment on lines
+81
to
+93
| @Test | ||
| void issue796_nullClassBodyDoesNotThrow() { | ||
| rewriteRun( | ||
| //language=java | ||
| java( | ||
| """ | ||
| class Outer { | ||
| enum Inner {} | ||
| } | ||
| """ | ||
| ) | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
This test also passes on main without any recipe changes, so I don't think it accurately reflects the issue we're intending to fix here. I also don't see the outer or inner class body parsed as null, so I'm not sure the conditionals added here would do anything in practice. What lead you to these changes?
Member
There was a problem hiding this comment.
Also since the nested inner enum isn't static, we wouldn't expect any action from the recipe either.
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullPointerException(NPE) inNestedEnumsAreNotStatic#796Problem
NestedEnumsAreNotStatic assumed all class declarations have a non-null body,
leading to a NullPointerException when analyzing certain nested enum constructs.
Solution
Testing