Conversation
rw251
force-pushed
the
rw/vaccine-report
branch
3 times, most recently
from
53d02bb to
f6e3de5
Compare
evansd
approved these changes
Sep 19, 2025
| VaccinationName, | ||
| VaccinationContent | ||
| FROM VaccinationReference | ||
| ORDER BY VaccinationName, VaccinationContent; |
Contributor
There was a problem hiding this comment.
Trivial thing, but it might be better to order by VaccinationContent first because that way products targeting the same pathogens will be grouped together. There's no consistent structure to the product names so the ordering there doesn't result in any meaningful groupings.
Contributor
Author
There was a problem hiding this comment.
That's a very good point - thanks - I'll update.
We want every combination of VaccinationName and VaccinationContent (target disease)
Currently this is just for vaccine name/target disease combos, but could in theory be extended to other similar things.
rw251
force-pushed
the
rw/vaccine-report
branch
from
f6e3de5 to
1342d18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of categorical values for vaccine name (
VaccinationName) and target disease (VaccinationContent) can be found in the output of existing queries. However users would find it useful to see which vaccines match with which target diseases. This PR produces that output and a report to display it.Here are a couple of threads requesting this feature:
https://bennettoxford.slack.com/archives/C069YDR4NCA/p1730805376684959
https://bennettoxford.slack.com/archives/C069YDR4NCA/p1756385458892829
https://bennettoxford.slack.com/archives/C096EMY1YDP/p1758011525215129