Skip to content

Conversation

@davidcui1225
Copy link
Contributor

Description

[Describe what this change achieves]

  • Add license headers to Workbench files
  • Change id to opensearch-query-workbench

Issues Resolved

[List any issues this PR will resolve]

  • Add license headers for OpenSearch
  • Change url for workbench to opensearch-query-workbench

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

describe('Test table display', () => {
beforeEach(() => {
cy.visit('app/opendistro-query-workbench');
cy.visit('app/opensearch-query-workbench');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an "API" change, aka did we need to preserve the old path with a redirect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not an API change, this changes the url display in OpenSearch-Dashboards. e.g when I visit query workbench, the url will look like localhost:5601/app/opensearch-query-workbench instead of opendistro

@davidcui1225 davidcui1225 merged commit b98b02c into develop Apr 19, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…-AOS-231-part-2

Update Vendor Name as of AOS-231
acarbonetto pushed a commit that referenced this pull request Aug 16, 2023
* [Spotless] Applying Google Code Format for integ-tests #10 (#329)

* Add spotless apply 33 files.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Addressed PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Address PR comments.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* fixing integ test failure.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Update integ-test/src/test/java/org/opensearch/sql/correctness/tests/TestConfigTest.java

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
mch2 pushed a commit to mch2/sql that referenced this pull request Nov 22, 2025
* Added support for Timestamp fields in filter

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

* Updated the condition in TypeConverted to handle timestamp udt

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

* Modifed the updateTimeStampFunction to handle recursively and updated checker method for timestamp udt

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>

---------

Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants