-
Notifications
You must be signed in to change notification settings - Fork 181
Add CBRT to the V2 engine #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CBRT to the V2 engine #1081
Conversation
126d176 to
eb2435a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (95.74%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 2.x #1081 +/- ##
============================================
- Coverage 98.27% 95.74% -2.54%
- Complexity 3434 3438 +4
============================================
Files 343 353 +10
Lines 8540 9206 +666
Branches 544 663 +119
============================================
+ Hits 8393 8814 +421
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dai-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Please double check if floating point precision problem may occur in assertion in UT.
|
Btw, we may want to add it to PPL grammar and doc too? |
|
@dai-chen I am working on a separate PR for adding CBRT() to the PPL. |
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
75142ab
eb2435a to
75142ab
Compare
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Description
Adds CBRT() math function to the V2 engine.
Usage: CBRT(number) calculates the cube root of a number
Argument type: INTEGER/LONG/FLOAT/DOUBLE
Return type: DOUBLE
(Non-negative) INTEGER/LONG/FLOAT/DOUBLE -> DOUBLE
(Negative) INTEGER/LONG/FLOAT/DOUBLE -> DOUBLE
Example::
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.