Add table write operator and builder #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (95.82%) is below the target coverage (99.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 2.x #1094 +/- ##
============================================
- Coverage 98.30% 95.82% -2.49%
- Complexity 3503 3535 +32
============================================
Files 340 356 +16
Lines 8652 9378 +726
Branches 550 673 +123
============================================
+ Hits 8505 8986 +481
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
dai-chen
force-pushed
the
add-table-write-builder
branch
from
f17622d to
9a7ca08
Compare
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
force-pushed
the
add-table-write-builder
branch
from
0baec59 to
03dd5ae
Compare
Signed-off-by: Chen Dai <daichen@amazon.com>
penghuo
approved these changes
Dec 12, 2022
joshuali925
approved these changes
Dec 14, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Add table write operator and builder Signed-off-by: Chen Dai <daichen@amazon.com> * Add UT for all new classes Signed-off-by: Chen Dai <daichen@amazon.com> * Rename child field Signed-off-by: Chen Dai <daichen@amazon.com> * Add columns field Signed-off-by: Chen Dai <daichen@amazon.com> * Update javadoc to prepare PR Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> (cherry picked from commit c494d92)
GabeFernandez310
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Dec 19, 2022
* Add table write operator and builder Signed-off-by: Chen Dai <daichen@amazon.com> * Add UT for all new classes Signed-off-by: Chen Dai <daichen@amazon.com> * Rename child field Signed-off-by: Chen Dai <daichen@amazon.com> * Add columns field Signed-off-by: Chen Dai <daichen@amazon.com> * Update javadoc to prepare PR Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
added a commit
that referenced
this pull request
Dec 22, 2022
* Add table write operator and builder Signed-off-by: Chen Dai <daichen@amazon.com> * Add UT for all new classes Signed-off-by: Chen Dai <daichen@amazon.com> * Rename child field Signed-off-by: Chen Dai <daichen@amazon.com> * Add columns field Signed-off-by: Chen Dai <daichen@amazon.com> * Update javadoc to prepare PR Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> (cherry picked from commit c494d92) Co-authored-by: Chen Dai <daichen@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similarly as #1091, add new
TableWriteBuilderas transition state between logical write and physical write operator.Issues Resolved
#1093
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.