Hot Fix For CI Build #1241

GabeFernandez310 · 2023-01-06T20:11:29Z

Signed-off-by: GabeFernandez310 Gabriel.Fernandez@improving.com

Description

Fixes CI build failure occurring in backport

Issues Resolved

Fixes #1236
https://github.com/opensearch-project/sql/actions/runs/3857798129/jobs/6575599281

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

dai-chen

Thanks for the quick fix!

After main branch fixed, should we close #1236 and create another one with this fix manually?

Yury-Fridlyand

CI failed

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

codecov-commenter · 2023-01-06T22:53:03Z

Codecov Report

Merging #1241 (a707e3f) into main (bac9c37) will decrease coverage by 35.48%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1241       +/-   ##
=============================================
- Coverage     98.24%   62.76%   -35.49%     
=============================================
  Files           332       10      -322     
  Lines          8399      658     -7741     
  Branches        513      119      -394     
=============================================
- Hits           8252      413     -7839     
- Misses          142      192       +50     
- Partials          5       53       +48

Flag	Coverage Δ
query-workbench	`62.76% <ø> (?)`
sql-engine	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...arch/storage/script/filter/FilterQueryBuilder.java
...l/opensearch/data/value/OpenSearchExprIpValue.java
...org/opensearch/sql/ppl/domain/PPLQueryRequest.java
...org/opensearch/sql/planner/DefaultImplementor.java
...ql/opensearch/storage/OpenSearchStorageEngine.java
...search/sql/expression/datetime/CalendarLookup.java
...opensearch/data/value/OpenSearchExprTextValue.java
...ensearch/sql/analysis/NamedExpressionAnalyzer.java
...arch/sql/expression/aggregation/MaxAggregator.java
...pensearch/storage/OpenSearchDataSourceFactory.java
... and 332 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

…Hot-Fix Hot Fix For CI Build (cherry picked from commit aae57a0) Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

* Add BWC tests for running against distribution bundle. (#1209) Signed-off-by: Zelin Hao <zelinhao@amazon.com> * Add Alternate Syntax For Match_Query And Other Functions (#1166) Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com> Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com> Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix Hot Fix For CI Build (cherry picked from commit aae57a0) Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Fixed error with single timestamp query (#1244) (#1246) Signed-off-by: vamsi-amazon <reddyvam@amazon.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com> (cherry picked from commit ee949cc) Co-authored-by: vamsi-amazon <reddyvam@amazon.com> * Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237) Added Testing And Implementation For Second_Of_Minute Function Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit dce7d0e) Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com> * Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252) * Add functions `ADDTIME` and `SUBTIME`. (#132) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 7630f87) Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239) Added Implementation And Testing For Day_Of_Week Function Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com> Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com> (cherry picked from commit bac9c37) Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com> * [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253) * Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230) Added Testing And Implementation For Minute_Of_Hour Function Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> (cherry picked from commit 61e2374) * Added Missing Imports Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> * Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255) * Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN. Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Support JOIN query on object field with unexpanded name (#1229) (#1250) * Resolve sub object field in search hit source Signed-off-by: Chen Dai <daichen@amazon.com> * Rename to unexpanded object Signed-off-by: Chen Dai <daichen@amazon.com> * Update IT with where condition Signed-off-by: Chen Dai <daichen@amazon.com> * Fix test index mapping Signed-off-by: Chen Dai <daichen@amazon.com> Signed-off-by: Chen Dai <daichen@amazon.com> (cherry picked from commit 151f4cc) Co-authored-by: Chen Dai <daichen@amazon.com> * Remove unnecessary scripts after repo split (#1256) Signed-off-by: Joshua Li <joshuali925@gmail.com> * Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258) Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com> (cherry picked from commit 6e72f18) Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> Signed-off-by: Zelin Hao <zelinhao@amazon.com> Signed-off-by: GabeFernandez310 <gabrielf@bitquilltech.com> Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> Signed-off-by: MitchellGale-BitQuill <mitchellg@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com> Co-authored-by: GabeFernandez310 <gabrielf@bitquilltech.com> Co-authored-by: YANGDB <yang.db.dev@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: vamsi-amazon <reddyvam@amazon.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com> Co-authored-by: Chen Dai <daichen@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com>

Fixed Imports

57e3250

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

GabeFernandez310 requested a review from a team as a code owner January 6, 2023 20:11

dai-chen previously approved these changes Jan 6, 2023

View reviewed changes

dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jan 6, 2023

Yury-Fridlyand requested changes Jan 6, 2023

View reviewed changes

Fixed Casting Issue

864099c

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

GabeFernandez310 dismissed dai-chen’s stale review via 864099c January 6, 2023 22:27

GabeFernandez310 requested a review from Yury-Fridlyand January 6, 2023 22:28

Fixed Unit Tests

a707e3f

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>

dai-chen approved these changes Jan 6, 2023

View reviewed changes

Yury-Fridlyand approved these changes Jan 6, 2023

View reviewed changes

YANG-DB merged commit aae57a0 into opensearch-project:main Jan 7, 2023

GabeFernandez310 mentioned this pull request Jan 7, 2023

[Backport 2.x] Add Alternate Syntax For Match_Query And Other Functions #1245

Merged

acarbonetto mentioned this pull request Jan 10, 2023

SQL ingestion and ops - standup #791

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hot Fix For CI Build #1241

Hot Fix For CI Build #1241

Uh oh!

GabeFernandez310 commented Jan 6, 2023

Uh oh!

dai-chen left a comment

Uh oh!

Yury-Fridlyand left a comment

Uh oh!

codecov-commenter commented Jan 6, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Hot Fix For CI Build #1241

Hot Fix For CI Build #1241

Uh oh!

Conversation

GabeFernandez310 commented Jan 6, 2023

Description

Issues Resolved

Check List

Uh oh!

dai-chen left a comment

Choose a reason for hiding this comment

Uh oh!

Yury-Fridlyand left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Jan 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Jan 6, 2023 •

edited

Loading