Support implicit type conversion from string to temporal #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
added
enhancement
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
6 tasks
dai-chen
pushed a commit
that referenced
this pull request
Jan 26, 2023
…1196) * Extend comparison methods to accept different datetime types. (#129) * Extend comparison methods to accept different datetime types. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework fix according to @dai-chen's comment. #1196 (review) * Revert `BinaryPredicateOperator`. * Add automatic cast rules `DATE`/`TIME`/`DATETIME` -> `DATETIME`/TIMESTAMP`. * Update unit tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add doctest sample. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Docs typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Minor comments update. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Modify `ExprCoreType` dependencies. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
…1196) * Extend comparison methods to accept different datetime types. (#129) * Extend comparison methods to accept different datetime types. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework fix according to @dai-chen's comment. #1196 (review) * Revert `BinaryPredicateOperator`. * Add automatic cast rules `DATE`/`TIME`/`DATETIME` -> `DATETIME`/TIMESTAMP`. * Update unit tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add doctest sample. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Docs typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Minor comments update. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Modify `ExprCoreType` dependencies. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit a4f8066)
dai-chen
pushed a commit
that referenced
this pull request
Jan 26, 2023
…1196) (#1294) * Extend comparison methods to accept different datetime types. (#129) * Extend comparison methods to accept different datetime types. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework fix according to @dai-chen's comment. #1196 (review) * Revert `BinaryPredicateOperator`. * Add automatic cast rules `DATE`/`TIME`/`DATETIME` -> `DATETIME`/TIMESTAMP`. * Update unit tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add doctest sample. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Docs typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Minor comments update. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Doctest typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Modify `ExprCoreType` dependencies. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit a4f8066) Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support implicit type conversion from STRING to DATE, TIME, TIMESTAMP, DATETIME.
Issues Resolved
#114
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.