Skip to content

Conversation

@GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Jan 23, 2023

Description

Legacy is disabled to force all integration tests to be run on the new engine. The test summary will be shown in GitHub Actions and can also be downloaded from the artifacts.
Screenshot 2023-01-17 at 3 25 37 PM

Issues Resolved

#1144

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GumpacG GumpacG requested a review from a team as a code owner January 23, 2023 20:55
#206)

* Added test summary workflow

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Disable the new engine

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Added failure detail to GH action summary

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Removed all text in body of xml files

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Upload xml file

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Install xmlstarlet to actions

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Cleaned up actions

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

* Removed white spaces

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG GumpacG force-pushed the integ-test-summary branch from 107020a to 4914771 Compare January 23, 2023 21:10
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes to track this progress!

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@MaxKsyunz MaxKsyunz merged commit c469a81 into opensearch-project:feature/remove-legacy-engine Jan 24, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ-test-summary branch January 24, 2023 19:23
@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants