Merge develop into main #142

davidcui1225 · 2021-06-25T21:46:40Z

Description

Merge develop into main and delete develop to use main as development branch moving forward. Will cut 1.0 and 1.x branches as well as per #135

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…tage (#108) * Support construct AggregationResponseParser during Aggregator build stage * modify the doc Signed-off-by: penghuo <penghuo@gmail.com>

* impl variance frontend and backend * Support construct AggregationResponseParser during Aggregator build stage * add var and varp for PPL Signed-off-by: penghuo <penghuo@gmail.com> * add UT Signed-off-by: penghuo <penghuo@gmail.com> * fix UT Signed-off-by: penghuo <penghuo@gmail.com> * fix doc format Signed-off-by: penghuo <penghuo@gmail.com> * fix doc format Signed-off-by: penghuo <penghuo@gmail.com> * fix the doc Signed-off-by: penghuo <penghuo@gmail.com> * add stddev_samp and stddev_pop Signed-off-by: penghuo <penghuo@gmail.com> * fix UT coverage * address comments Signed-off-by: penghuo <penghuo@gmail.com>

* Take the condition expression as property to the named aggregator when wrapping the delegated aggregator Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * Added test case where filtered agg is not pushed down Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com> * update Signed-off-by: chloe-zh <chloezh1102@gmail.com>

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

Signed-off-by: David Cui <davidcui@amazon.com>

* Deprecated cursor enabling and fetch size setting Signed-off-by: penghuo <penghuo@gmail.com> * update doc Signed-off-by: penghuo <penghuo@gmail.com> * add more deprecated settings Signed-off-by: penghuo <penghuo@gmail.com>

* add codecov to CI workflow Signed-off-by: David Cui <davidcui@amazon.com> * add codecov token Signed-off-by: David Cui <davidcui@amazon.com>

* save progress on doc renaming * update rest of documentation links Signed-off-by: David Cui <davidcui@amazon.com> * add workbench developer guide and update readme Signed-off-by: David Cui <davidcui@amazon.com> * Bump glob-parent from 5.1.1 to 5.1.2 in /workbench Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2. - [Release notes](https://github.com/gulpjs/glob-parent/releases) - [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md) - [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2) --- updated-dependencies: - dependency-name: glob-parent dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * add testing-library Signed-off-by: David Cui <davidcui@amazon.com> * rename workbench artifact name to kebab case Signed-off-by: David Cui <davidcui@amazon.com> * standardize maintainers list based on team roles, fix workbench name in dev guide Signed-off-by: David Cui <davidcui@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

codecov-commenter · 2021-06-25T21:47:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@94a059a). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage        ?   99.89%           
  Complexity      ?     2471           
=======================================
  Files           ?      245           
  Lines           ?     5748           
  Branches        ?      333           
=======================================
  Hits            ?     5742           
  Misses          ?        5           
  Partials        ?        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chloe-zh · 2021-06-25T21:50:23Z

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before. You can do this either by reverting the PR and re open a PR that destinates dev, or by cherry picking the commit to dev directly I think

joshuali925 · 2021-06-25T21:52:46Z

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before

I checked #128 as well, but this PR merges develop to main, I don't think it is affected?

chloe-zh · 2021-06-25T22:00:17Z

Could you help deal with #128 before merge dev to main, I mistakenly merged the PR to main days before

I checked #128 as well, but this PR merges develop to main, I don't think it is affected?

My bad, I thought we would still use the dev branch as our default branch, so it should be always consistent or ahead of main. Yes you are right, it does not matter if we are removing dev branch.

chloe-zh

LGTM once the link checker is fixed. Thanks!

Signed-off-by: David Cui <davidcui@amazon.com>

sql-odbc/docs/dev/sign_installers.md

…rs url Signed-off-by: David Cui <davidcui@amazon.com>

Signed-off-by: David Cui <davidcui@amazon.com>

penghuo

Thanks for the change!

Signed-off-by: David Cui <davidcui@amazon.com>

penghuo and others added 8 commits June 8, 2021 14:39

Support construct AggregationResponseParser during Aggregator build s…

b39e7b6

…tage (#108) * Support construct AggregationResponseParser during Aggregator build stage * modify the doc Signed-off-by: penghuo <penghuo@gmail.com>

Rename gradle tasks in the manner of Opensearch (#133)

70af5bd

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

add testing-library/user-event to pass CI (#141)

2025fa9

Signed-off-by: David Cui <davidcui@amazon.com>

Deprecated legacy settings instead of removing (#140)

51864a2

* Deprecated cursor enabling and fetch size setting Signed-off-by: penghuo <penghuo@gmail.com> * update doc Signed-off-by: penghuo <penghuo@gmail.com> * add more deprecated settings Signed-off-by: penghuo <penghuo@gmail.com>

Add Codecov to SQL (#138)

b7f8060

* add codecov to CI workflow Signed-off-by: David Cui <davidcui@amazon.com> * add codecov token Signed-off-by: David Cui <davidcui@amazon.com>

davidcui1225 requested review from chloe-zh, joshuali925 and penghuo June 25, 2021 21:46

joshuali925 approved these changes Jun 25, 2021

View reviewed changes

chloe-zh approved these changes Jun 25, 2021

View reviewed changes

davidcui1225 added 4 commits June 25, 2021 16:13

add links to exclude from link checker

29d26c7

Signed-off-by: David Cui <davidcui@amazon.com>

fix localhost exclusion flag

9a6021b

Signed-off-by: David Cui <davidcui@amazon.com>

add all exclusion links, revert localhost exclusion away from regex

a8b1c03

Signed-off-by: David Cui <davidcui@amazon.com>

fix family.zzz exclusion, remove stale link from odbc sign_installers

e7b0aa6

Signed-off-by: David Cui <davidcui@amazon.com>

joshuali925 reviewed Jun 25, 2021

View reviewed changes

sql-odbc/docs/dev/sign_installers.md Outdated Show resolved Hide resolved

davidcui1225 added 2 commits June 25, 2021 17:03

fix lychee workflow after local testing and replace old sign_installe…

2e0edfa

…rs url Signed-off-by: David Cui <davidcui@amazon.com>

remove accidental duplicate exclude flag

68fd7f4

Signed-off-by: David Cui <davidcui@amazon.com>

penghuo approved these changes Jun 26, 2021

View reviewed changes

remove sign installers as it is out of date

692f514

Signed-off-by: David Cui <davidcui@amazon.com>

davidcui1225 merged commit 254510e into main Jun 26, 2021

davidcui1225 deleted the develop branch June 26, 2021 00:47

acarbonetto mentioned this pull request Nov 3, 2022

SQL ingestion and ops - standup #791

Closed

Yury-Fridlyand mentioned this pull request Feb 2, 2023

Rework on OpenSearchDataType: parse, store and use mapping information #1314

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge develop into main #142

Merge develop into main #142

Uh oh!

davidcui1225 commented Jun 25, 2021

Uh oh!

codecov-commenter commented Jun 25, 2021 •

edited by codecov bot

Loading

Uh oh!

chloe-zh commented Jun 25, 2021 •

edited

Loading

Uh oh!

joshuali925 commented Jun 25, 2021

Uh oh!

chloe-zh commented Jun 25, 2021

Uh oh!

chloe-zh left a comment

Uh oh!

Uh oh!

penghuo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Merge develop into main #142

Merge develop into main #142

Uh oh!

Conversation

davidcui1225 commented Jun 25, 2021

Description

Check List

Uh oh!

codecov-commenter commented Jun 25, 2021 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chloe-zh commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshuali925 commented Jun 25, 2021

Uh oh!

chloe-zh commented Jun 25, 2021

Uh oh!

chloe-zh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

penghuo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-commenter commented Jun 25, 2021 •

edited by codecov bot

Loading

chloe-zh commented Jun 25, 2021 •

edited

Loading