Skip to content

[Backport 2.x] Backport breaking changes #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derek-ho merged 4 commits into from
Aug 3, 2023
Merged

[Backport 2.x] Backport breaking changes #1920

derek-ho merged 4 commits into from
Aug 3, 2023

Conversation

@opensearch-trigger-bot
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Aug 1, 2023 •
edited by Yury-Fridlyand
Loading

@github-actions
Fix create_index/create_index_with_IOException issue caused by OpenSe…
f0dda05 
…arch PR change (#1899)

* Added setDefaultMediaType for create_index and create_index_with_IOException

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@Yury-Fridlyand
Copy link
Collaborator

Yury-Fridlyand commented Aug 1, 2023

opensearch-project/OpenSearch#9033

Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 1, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #1920 (1f259ca) into 2.x (031183d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1920   +/-   ##
=========================================
  Coverage     97.42%   97.42%           
  Complexity     4648     4648           
=========================================
  Files           408      408           
  Lines         11528    11528           
  Branches        839      839           
=========================================
  Hits          11231    11231           
  Misses          290      290           
  Partials          7        7
Flag Coverage Δ
sql-engine 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../opensearch/monitor/OpenSearchResourceMonitor.java 100.00% <ø> (ø)
...l/opensearch/setting/LegacyOpenDistroSettings.java 100.00% <ø> (ø)

acarbonetto
acarbonetto previously approved these changes Aug 1, 2023
View reviewed changes
Yury-Fridlyand and others added 3 commits August 1, 2023 15:13
@Yury-Fridlyand
Fix renamed imports (#1911)
b303acf 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@GumpacG @Yury-Fridlyand
Merge pull request #1914 from Bit-Quill/fix-breaking-changes-Nth-time
05d3392 
Fix breaking changes.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@GumpacG @Yury-Fridlyand
Fixed imports (#1919)
1f259ca 
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand dismissed stale reviews from acarbonetto and themself via 1f259ca August 2, 2023 02:27
@Yury-Fridlyand Yury-Fridlyand changed the title [Backport 2.x] Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change [Backport 2.x] Backport breaking changes Aug 2, 2023
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Aug 2, 2023
Closed
@derek-ho derek-ho merged commit a297d33 into 2.x Aug 3, 2023
@derek-ho derek-ho deleted the backport/backport-1899-to-2.x branch August 3, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derek-ho derek-ho derek-ho approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

+2 more reviewers

@MitchellGale MitchellGale MitchellGale approved these changes

@matthewryanwells matthewryanwells matthewryanwells approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autocut

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Yury-Fridlyand @derek-ho @acarbonetto @MitchellGale @matthewryanwells @GumpacG