[Spotless] Applying Google Code Format for sql files #11 #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Spotless apply, ignore checkstyle, manual java doc fixes. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
Yury-Fridlyand
previously approved these changes
Aug 15, 2023
| /** | ||
| * Argument "asc" is required. | ||
| * Argument "nullFirst" is optional and determined by Analyzer later if absent. | ||
| * Argument "asc" is required. Argument "nullFirst" is optional and determined by Analyzer later |
Collaborator
There was a problem hiding this comment.
I think this comment is outdated and can be removed.
Contributor
Author
There was a problem hiding this comment.
Are you addressing the entire comment?
Collaborator
There was a problem hiding this comment.
Yes, the function signature was changed, but comment isn't
Collaborator
There was a problem hiding this comment.
You can fix it or leave it. The change request is unrelated to your work.
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Codecov Report
@@ Coverage Diff @@
## main #1968 +/- ##
============================================
- Coverage 97.51% 97.51% -0.01%
- Complexity 4656 4657 +1
============================================
Files 408 408
Lines 11932 11912 -20
Branches 829 828 -1
============================================
- Hits 11636 11616 -20
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yury-Fridlyand
previously approved these changes
Aug 16, 2023
GumpacG
previously approved these changes
Aug 16, 2023
sql/src/test/java/org/opensearch/sql/sql/antlr/HighlightTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/opensearch/sql/sql/antlr/HighlightTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/opensearch/sql/sql/antlr/HighlightTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/opensearch/sql/sql/antlr/SQLSyntaxParserTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/opensearch/sql/sql/antlr/SQLSyntaxParserTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/opensearch/sql/sql/antlr/SQLSyntaxParserTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/opensearch/sql/sql/antlr/SQLSyntaxParserTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/opensearch/sql/sql/parser/AstBuilderTest.java
Outdated
Show resolved
Hide resolved
sql/src/test/java/org/opensearch/sql/sql/parser/context/QuerySpecificationTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
MitchellGale
dismissed stale reviews from GumpacG and Yury-Fridlyand
via
d27f788
Yury-Fridlyand
previously approved these changes
Aug 16, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Yury-Fridlyand
approved these changes
Aug 16, 2023
acarbonetto
approved these changes
Aug 16, 2023
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 22, 2023
…project#1968) * [Spotless] Applying Google Code Format for sql files #11 (#330) * Spotless apply, ignore checkstyle, manual java doc fixes. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply suggestions from code review Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies spotless for SQL directory in project. Sets checkstyle to not fail on failure for sql directory.
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.