[Spotless] Applying Google Code Format for protocol files #14 #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
previously approved these changes
Aug 16, 2023
protocol/src/main/java/org/opensearch/sql/protocol/response/format/RawResponseFormatter.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1971 +/- ##
============================================
- Coverage 97.52% 97.52% -0.01%
+ Complexity 4657 4655 -2
============================================
Files 408 408
Lines 11952 11944 -8
Branches 829 829
============================================
- Hits 11656 11648 -8
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…rmat/RawResponseFormatter.java Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Yury-Fridlyand
previously approved these changes
Aug 16, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Yury-Fridlyand
previously approved these changes
Aug 16, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
pjfitzgibbons
previously approved these changes
Aug 16, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Yury-Fridlyand
previously approved these changes
Aug 17, 2023
GumpacG
reviewed
Aug 17, 2023
.../src/test/java/org/opensearch/sql/protocol/response/format/CommandResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/CsvResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/CsvResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/CsvResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/CsvResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/RawResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/RawResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/RawResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/RawResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
...ocol/src/test/java/org/opensearch/sql/protocol/response/format/RawResponseFormatterTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
GumpacG
approved these changes
Aug 17, 2023
Yury-Fridlyand
approved these changes
Aug 17, 2023
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 22, 2023
…arch-project#1971) * Spotless apply on protocol Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * added ignorefailures Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Update protocol/src/main/java/org/opensearch/sql/protocol/response/format/RawResponseFormatter.java Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * Apply suggestions from code review Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies spotless for protocol directory in project. Sets checkstyle to not fail on failure for protocol directory.
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.