[Backport 2.x] [Spotless] Applying Google Code Format for core/src/main files #4 #1933 #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensearch-project#1933) * GJF part 4 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add build.gradle comment to mention why we are ignoring checkstyle failures for core. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fix include spotless build gradle. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert astDSL.JAVA Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert ast changes as was covered in spotless #1 PR for GJF. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Reverting commits in ast folder attempt #2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert change to RaretopN.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Replacing removed include in spotless. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
MitchellGale
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #1995 +/- ##
=========================================
Coverage 97.42% 97.42%
Complexity 4646 4646
=========================================
Files 408 408
Lines 11525 11525
Branches 835 835
=========================================
Hits 11228 11228
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
acarbonetto
previously approved these changes
Aug 21, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Collaborator
|
Conflicts |
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Yury-Fridlyand
approved these changes
Aug 21, 2023
acarbonetto
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies Spotless on Java code for:
'core/src/main/java/org/opensearch/sql/DataSourceSchemaName.java',
'core/src/test/java/org/opensearch/sql/data/.java',
'core/src/test/java/org/opensearch/sql/config/.java',
'core/src/test/java/org/opensearch/sql/analysis/*.java'
Disables core checkstyle and enables spotless check for files that are fixed in this PR.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.