[Backport 2.x] [Spotless] Backport of #6, #7 spotless PR #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchellGale
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
…earch-project#1939) * Spotless apply for datasources. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * ignore checkstyle for datasources Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
…ect#1940) * Spotless apply for common directory. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Igoring checkstyle for common Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Spotless apply on string utils, Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Typo fix Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MitchellGale
force-pushed
the
Spotless_Backport_6_pt2
branch
from
4db7c7e to
9ddd896
Compare
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
changed the title
Codecov Report
@@ Coverage Diff @@
## 2.x #2012 +/- ##
=========================================
Coverage 97.51% 97.51%
Complexity 4658 4658
=========================================
Files 408 408
Lines 11931 11934 +3
Branches 831 830 -1
=========================================
+ Hits 11634 11638 +4
+ Misses 290 289 -1
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Comment on lines
15
to
27
| * Unquote any string with mark specified. | ||
| * @param text string | ||
| * @param mark quotation mark | ||
| * @return An unquoted string whose outer pair of (single/double/back-tick) quotes have been | ||
| * removed | ||
| */ | ||
| public static String unquote(String text, String mark) { | ||
| if (isQuoted(text, mark)) { | ||
| return text.substring(mark.length(), text.length() - mark.length()); | ||
| } | ||
| return text; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Please revert backporting breaking changes from #1206
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
acarbonetto
previously approved these changes
Aug 22, 2023
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports several spotless PRs to 2.x
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.