Fix issue of workbench not outputting errors #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
approved these changes
May 6, 2021
davidcui1225
added a commit
that referenced
this pull request
May 6, 2021
Signed-off-by: David Cui <davidcui@amazon.com>
davidcui1225
added a commit
that referenced
this pull request
May 6, 2021
Signed-off-by: David Cui <davidcui@amazon.com>
davidcui1225
pushed a commit
that referenced
this pull request
May 10, 2021
* fixed no-error-output bug in workbench (#32) Signed-off-by: David Cui <davidcui@amazon.com> * Update issue template with multiple labels Signed-off-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: Vacha Shah <vachshah@amazon.com>
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chloe Zhang chloezh1102@gmail.com
Description
Here was a rule to mark the result as a proper output from http response rather than error output, which is applied when the http response has data body even though the status is not "ok" (response ok is false). This condition was added specially to fix the csv downloading issue, details: opendistro-for-elasticsearch/sql#1023
But the temporary fix gave a much wider condition than necessary to mark a result as a "good result". This results in some improper behaviors, it does not show any error message in the output windows now when it should.
This fix is to give a restriction to the last fix of the csv downloading issue. However this fix is only a temporary solution to unblock the release. We should dive deep for better solution to stabilize the workbench.
Issues Resolved
Errors are not output in workbench. No GitHub issues are applicable.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.