Implement cryptographic hash UDFs #3574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
yuancu
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Member
|
A high-level question: could you explain in PR description why choose to self-implement instead of leveraging Calcite builtin functions (This question should be answered for each function in similar PRs) |
LantaoJin
reviewed
Apr 24, 2025
|
|
||
| Example:: | ||
|
|
||
| os> source=people | eval `SHA1('hello')` = SHA1('hello') | fields `SHA1('hello')` |
Member
There was a problem hiding this comment.
please apply function on field of people index
Collaborator
Author
There was a problem hiding this comment.
Tests are corrected. Document kept unchanged.
|
|
||
| Example:: | ||
|
|
||
| os> source=people | eval `SHA2('hello',256)` = SHA2('hello',256) | fields `SHA2('hello',256)` |
| | 2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824 | | ||
| +------------------------------------------------------------------+ | ||
|
|
||
| os> source=people | eval `SHA2('hello',512)` = SHA2('hello',512) | fields `SHA2('hello',512)` |
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Collaborator
Author
I found that |
LantaoJin
previously approved these changes
Apr 24, 2025
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
LantaoJin
approved these changes
May 9, 2025
LantaoJin
previously approved these changes
May 9, 2025
|
|
||
| // Register PPL UDF operator | ||
| registerOperator(SPAN, PPLBuiltinOperators.SPAN); | ||
| registerOperator(SHA2, PPLBuiltinOperators.SHA2); |
Member
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
I'm okay with using SHA2, as it provides more functionality.
penghuo
reviewed
May 9, 2025
core/src/main/java/org/opensearch/sql/expression/function/udf/CryptographicFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/function/udf/CryptographicFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/expression/function/udf/CryptographicFunction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
LantaoJin
approved these changes
May 12, 2025
penghuo
approved these changes
May 12, 2025
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Implement cryptographic functions Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Implement cryptographic UDFs Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Wrap message digests with ThreadLocal to enforce thread safety Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Create documentation for cryptographic hash PPL functions Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Use calcite implementations of md5 and sha1 Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Test field values in cryptographic UDFs Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Refactor: update sha2 implementations with DigestUtils Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> --------- Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
7 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
SHA2with UDFs, and reuse calciteMD5,SHA1sql operators as available functions.SHA2family is not fully implemented in Calcite SQL functions - onlySHA256andSHA512are available,SHA224andSHA384are missing. Therefore, we implement our own.Issues Resolved
Resolves #3573
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.