Implement cidrmatch udf with Calcite
#3603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
yuancu
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
dai-chen
reviewed
May 7, 2025
core/src/main/java/org/opensearch/sql/expression/function/udf/ip/CidrMatchFunction.java
Show resolved
Hide resolved
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
qianheng-aws
previously approved these changes
May 8, 2025
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
dai-chen
approved these changes
May 19, 2025
LantaoJin
reviewed
May 21, 2025
| Usage: `cidrmatch(ip, cidr)` checks if `ip` is within the specified `cidr` range. | ||
|
|
||
| Argument type: STRING, STRING | ||
| Argument type: STRING/IP, STRING |
Member
There was a problem hiding this comment.
Is the IP argument supported in v2?
Collaborator
Author
There was a problem hiding this comment.
Yes. I've tested. It doesn't work in v2.19 but works in v3.1.0 with calcite disabled.
According to the implementation at IPFunctions.java#L36, IP is the only supported argument type. Strings may be cast to IP.
The documentation may be out of date since the IP's PR came later that cidrmatch's PR. cidrmatch is implemented in #3110; IP data type is added in #3145 .
LantaoJin
approved these changes
May 22, 2025
This was referenced May 22, 2025
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Implement cidrmatch UDF Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Add class documentation for cidrmatch udf Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Update cidrmatch doc: add IP as an acceptable parameter type Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> --------- Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
CIDRMATCHon Calcite engine with a UDFIssues Resolved
Resolves #3505
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.