[Backport 2.19-dev] Support timechart command with Calcite (#3993) #4232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selsong
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
selsong
force-pushed
the
backport/backport-3993-to-2.19-dev
branch
2 times, most recently
from
9e73e12 to
e21ec51
Compare
* WIP: Support timechart grammar / AST Signed-off-by: Selina Song <selsong@amazon.com> * WIP: Support span=unit in timechart Signed-off-by: Selina Song <selsong@amazon.com> * Return correct column format after span=unit Signed-off-by: Selina Song <selsong@amazon.com> * sort by @timestamp, group by aggregate function Signed-off-by: Selina Song <selsong@amazon.com> * WIP: pivot table by field Signed-off-by: Selina Song <selsong@amazon.com> * Correct pivot format for by field Signed-off-by: Selina Song <selsong@amazon.com> * Fix aggregation composite bucket limit Signed-off-by: Selina Song <selsong@amazon.com> * Add timechart.rst doc and PPLQueryAnonymizer test Signed-off-by: Selina Song <selsong@amazon.com> * Add ExplainIT for timechart Signed-off-by: Selina Song <selsong@amazon.com> * Restore reverse ExplainIT Signed-off-by: Selina Song <selsong@amazon.com> * Update explainIT timechart Signed-off-by: Selina Song <selsong@amazon.com> * spotlessApply formatting Signed-off-by: Selina Song <selsong@amazon.com> * format IT Signed-off-by: Selina Song <selsong@amazon.com> * Add limit parameter Signed-off-by: Selina Song <selsong@amazon.com> * Add limit=0 means no limit, show all values, no other Signed-off-by: Selina Song <selsong@amazon.com> * Add useother parameter Signed-off-by: Selina Song <selsong@amazon.com> * clean up format, fix column order Signed-off-by: Selina Song <selsong@amazon.com> * add test for formatter Signed-off-by: Selina Song <selsong@amazon.com> * Increase test coverage for formatter Signed-off-by: Selina Song <selsong@amazon.com> * Rename bin option expression, modify constructor Signed-off-by: Selina Song <selsong@amazon.com> * Make test data smaller, update IT, rst Signed-off-by: Selina Song <selsong@amazon.com> * add explain output to IT Signed-off-by: Selina Song <selsong@amazon.com> * Add limitation to rst, format, comment Signed-off-by: Selina Song <selsong@amazon.com> * Add test coverage formatter Signed-off-by: Selina Song <selsong@amazon.com> * Refactor formatter for clarity Signed-off-by: Selina Song <selsong@amazon.com> * fix NPE Signed-off-by: Selina Song <selsong@amazon.com> * add import Signed-off-by: Selina Song <selsong@amazon.com> * update mapping to match smaller dataset Signed-off-by: Selina Song <selsong@amazon.com> * update explainIT Signed-off-by: Selina Song <selsong@amazon.com> * Fix explainIT, improve code structure Signed-off-by: Selina Song <selsong@amazon.com> * spotless Signed-off-by: Selina Song <selsong@amazon.com> * Support diff position parameters, count default 0 not null, update doc rst Signed-off-by: Selina Song <selsong@amazon.com> * fix count aggr type int Signed-off-by: Selina Song <selsong@amazon.com> * rename @timestamp column Signed-off-by: Selina Song <selsong@amazon.com> * move parameter extraction to PPLService Signed-off-by: Selina Song <selsong@amazon.com> * clean up PPLService Signed-off-by: Selina Song <selsong@amazon.com> * fix count type test, doc rst format Signed-off-by: Selina Song <selsong@amazon.com> * add test coverage Signed-off-by: Selina Song <selsong@amazon.com> * WIP: SQL query with limit useother Signed-off-by: Selina Song <selsong@amazon.com> * revert QueryService Signed-off-by: Selina Song <selsong@amazon.com> * add limit useother to SQL query Signed-off-by: Selina Song <selsong@amazon.com> * SQL query working, WIP column rename Signed-off-by: Selina Song <selsong@amazon.com> * use loadIndex in IT Signed-off-by: Selina Song <selsong@amazon.com> * Rename fields to match, update doc Signed-off-by: Selina Song <selsong@amazon.com> * revert QueryResult Signed-off-by: Selina Song <selsong@amazon.com> * revert gradle build Signed-off-by: Selina Song <selsong@amazon.com> * fix format Signed-off-by: Selina Song <selsong@amazon.com> * Add count fill zero, update toSQL tests, doc Signed-off-by: Selina Song <selsong@amazon.com> * fix nits Signed-off-by: Selina Song <selsong@amazon.com> * Fix rename aggregation only no by field Signed-off-by: Selina Song <selsong@amazon.com> * Update SQL test Signed-off-by: Selina Song <selsong@amazon.com> * revert OS Exec Engine edits Signed-off-by: Selina Song <selsong@amazon.com> * correct OS Exec Engine revert to 5ec9603 Signed-off-by: Selina Song <selsong@amazon.com> * restore OS Exec Engine Signed-off-by: Selina Song <selsong@amazon.com> * update QueryAnonymizer Test to reflect default Signed-off-by: Selina Song <selsong@amazon.com> * WIP: Add null=1, Other fill zero wip Signed-off-by: Selina Song <selsong@amazon.com> * Add doctest and update ExplainIT Signed-off-by: Selina Song <selsong@amazon.com> * Replace detectFieldIndices function Signed-off-by: Selina Song <selsong@amazon.com> * update explainIT Signed-off-by: Selina Song <selsong@amazon.com> * Fix Other in zero fill case Signed-off-by: Selina Song <selsong@amazon.com> * Fix OTHER in zero fill case Signed-off-by: Selina Song <selsong@amazon.com> * spotless format Signed-off-by: Selina Song <selsong@amazon.com> * update doc with null example Signed-off-by: Selina Song <selsong@amazon.com> * null not included in limit calc Signed-off-by: Selina Song <selsong@amazon.com> * update SQL test Signed-off-by: Selina Song <selsong@amazon.com> * update SQL test format Signed-off-by: Selina Song <selsong@amazon.com> * Update ExplainIT with count Signed-off-by: Selina Song <selsong@amazon.com> * remove unused code Signed-off-by: Selina Song <selsong@amazon.com> * Fix SQL tests nullable Signed-off-by: Selina Song <selsong@amazon.com> * spotless format Signed-off-by: Selina Song <selsong@amazon.com> --------- Signed-off-by: Selina Song <selsong@amazon.com> Signed-off-by: Selina Song <selinasong6@gmail.com> Co-authored-by: Selina Song <selsong@amazon.com> (cherry picked from commit e2678a1)
selsong
force-pushed
the
backport/backport-3993-to-2.19-dev
branch
from
370b35d to
f6469d0
Compare
Signed-off-by: Selina Song <selsong@amazon.com>
Swiddis
approved these changes
Sep 5, 2025
qianheng-aws
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #3993 timechart PR into 2.19-dev branch
manual backport due to conflict