[Backport 2.19-dev] Speed up aggregation pushdown for single group-by expression (#3550) #4285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch-project#3550) * Speed up aggregation pushdown for single group-by expression Signed-off-by: Lantao Jin <ltjin@amazon.com> * Add configs nullable_bucket Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix IT Signed-off-by: Lantao Jin <ltjin@amazon.com> * revert typo Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix conflicts error Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix unit tests Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix order Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix UT Signed-off-by: Lantao Jin <ltjin@amazon.com> * Fix UT in windows Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix compile error of conflicts Signed-off-by: Lantao Jin <ltjin@amazon.com> * Add more ITs after merging push down limit to agg buckets Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix IT Signed-off-by: Lantao Jin <ltjin@amazon.com> * address comments Signed-off-by: Lantao Jin <ltjin@amazon.com> * Clear sorts in source builder for aggregation pushdown Signed-off-by: Lantao Jin <ltjin@amazon.com> * Delete the TODO of v2, it's resolved now Signed-off-by: Lantao Jin <ltjin@amazon.com> * fix doctest Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 0e2dc7c)
LantaoJin
changed the title
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
penghuo
approved these changes
Sep 12, 2025
qianheng-aws
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked #3550 from commit 0e2dc7c)