Scale of decimal literal should always be positive in Calcite #4401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
LantaoJin
commented
Sep 29, 2025
| // In v3, a decimal literal will be kept in Calcite RexNode and converted back to double | ||
| // in runtime. | ||
| return new Literal(BigDecimal.valueOf(Double.parseDouble(ctx.getText())), DataType.DECIMAL); | ||
| return new Literal(new BigDecimal(ctx.getText()), DataType.DECIMAL); |
Member
Author
There was a problem hiding this comment.
This line fixes the issue.
qianheng-aws
approved these changes
Sep 29, 2025
yuancu
approved these changes
Sep 29, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 29, 2025
* Fix IT Signed-off-by: Lantao Jin <ltjin@amazon.com> * remove unused class Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit d567ec8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
asifabashar
added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
* main-apple: (218 commits) Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442) Create fab-radar.yml PPL `fillnull` command enhancement (opensearch-project#4421) reverting to _doc + _id (opensearch-project#4435) Support `multisearch` command in calcite (opensearch-project#4332) Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423) [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418) Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378) [Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344) Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613) Version bump: 3.3 (opensearch-project#4417) Add max/min eval functions (opensearch-project#4333) Support time modifiers in search command (opensearch-project#4224) Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402) refactor span (opensearch-project#4334) Move release notes categories (opensearch-project#3818) [Doc] Enable doctest with Calcite (opensearch-project#4379) Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407) Scale of decimal literal should always be positive in Calcite (opensearch-project#4401) Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372) ...
LantaoJin
added a commit
to LantaoJin/search-plugins-sql
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
added a commit
that referenced
this pull request
Oct 10, 2025
LantaoJin
pushed a commit
that referenced
this pull request
Oct 10, 2025
penghuo
pushed a commit
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calcite
makeExactLiteral()cannot accept negative scale of decimal literal.But when a Double value convert to BigDecimal, its scale could be negative due to Double's scientific notation. For example,
b.scale()return-3Related Issues
Resolves #4391
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.