Skip to content

Fix join type ambiguous issue when specify the join type with sql-like join criteria #4474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qianheng-aws merged 1 commit into from
Oct 9, 2025
Merged

Fix join type ambiguous issue when specify the join type with sql-like join criteria #4474

qianheng-aws merged 1 commit into from
Oct 9, 2025

Conversation

@LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Oct 9, 2025 •
edited
Loading

Description

Issue happens when use sql-like join criteria e.g. on l.key=r.key with specific join type argument type=xxx:

| join type=left left=RATING right=PRODUCT ON RATING.product_id = PRODUCT.product_id

throws Join type is ambiguous, remove either the join type before JOIN keyword or ..

Related Issues

Resolves #4459

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LantaoJin
Fix join type ambiguous issue when specify the join type with sql-lik…
c95d323 
…e join criteria

Signed-off-by: Lantao Jin <ltjin@amazon.com>
@LantaoJin LantaoJin marked this pull request as ready for review October 9, 2025 08:19
@LantaoJin LantaoJin added bug Something isn't working backport 2.19-dev labels Oct 9, 2025
@LantaoJin
Copy link
Member Author

LantaoJin commented Oct 9, 2025

Should we backport this to 3.3 branch? @penghuo

@qianheng-aws qianheng-aws merged commit 3d2043d into opensearch-project:main Oct 9, 2025
37 of 40 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2025
@github-actions
Fix join type ambiguous issue when specify the join type with sql-lik…
bbc23da 
…e join criteria (#4474)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
(cherry picked from commit 3d2043d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 9, 2025
Merged
LantaoJin pushed a commit that referenced this pull request Oct 9, 2025
@opensearch-trigger-bot @github-actions
Fix join type ambiguous issue when specify the join type with sql-lik…
a42c05b 
…e join criteria (#4474) (#4476)

(cherry picked from commit 3d2043d)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2025
@github-actions
Fix join type ambiguous issue when specify the join type with sql-lik…
d52332e 
…e join criteria (#4474)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
(cherry picked from commit 3d2043d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 10, 2025
Merged
LantaoJin pushed a commit that referenced this pull request Oct 10, 2025
@opensearch-trigger-bot
Fix join type ambiguous issue when specify the join type with sql-lik…
4df3f40 
…e join criteria (#4474) (#4504)
sandeshkr419 added a commit to sandeshkr419/sql that referenced this pull request Dec 3, 2025
@sandeshkr419 @github-actions
@Swiddis @manasvinibs @opensearch-ci-bot @noCharger @dai-chen @Mebsina @yuancu @opensearch-trigger-bot @ahkcs @penghuo @alexey-temnikov @RileyJergerAmazon @ykmr1224 @LantaoJin @songkant-aws @qianheng-aws @xinyual @RyanL1997 @peterzhuamazon @vinaykpud @expani @vamsimanohar @ritvibhatt @ishaoxy @mch2
Data fusion changes
6f7fd68 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
Co-authored-by: Manasvini B S <manasvis@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Louis Chu <clingzhi@amazon.com>
Co-authored-by: Chen Dai <daichen@amazon.com>
Co-authored-by: Mebsina <cnoramut@gmail.com>
Co-authored-by: Yuanchun Shen <yuanchu@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kai Huang <105710027+ahkcs@users.noreply.github.com>
Co-authored-by: Peng Huo <penghuo@gmail.com>
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
Co-authored-by: Riley Jerger <214163063+RileyJergerAmazon@users.noreply.github.com>
Co-authored-by: Tomoyuki MORITA <moritato@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: Songkan Tang <songkant@amazon.com>
Co-authored-by: qianheng <qianheng@amazon.com>
Co-authored-by: Simeon Widdis <sawiddis@gmail.com>
Co-authored-by: Xinyuan Lu <xinyual@amazon.com>
Co-authored-by: Jialiang Liang <jiallian@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Co-authored-by: expani <anijainc@amazon.com>
Co-authored-by: expani1729 <110471048+expani@users.noreply.github.com>
Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
Co-authored-by: ritvibhatt <53196324+ritvibhatt@users.noreply.github.com>
Co-authored-by: Xinyu Hao <75524174+ishaoxy@users.noreply.github.com>
Co-authored-by: Marc Handalian <marc.handalian@gmail.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Fix join type ambiguous issue when specify the join type with sql-like join criteria (opensearch-project#4474)
Fix issue 4441 (opensearch-project#4449)
Fix missing keywordsCanBeId (opensearch-project#4491)
Fix the bug of explicit makeNullLiteral for UDT fields (opensearch-project#4475)
Fix mapping after aggregation push down (opensearch-project#4500)
Fix percentile bug (opensearch-project#4539)
Fix JsonExtractAllFunctionIT failure (opensearch-project#4556)
Fix sort push down into agg after project already pushed (opensearch-project#4546)
Fix push down failure for min/max on derived field (opensearch-project#4572)
Fix compile issue in main (opensearch-project#4608)
Fix filter parsing failure on date fields with non-default format (opensearch-project#4616)
Fix bin nested fields issue (opensearch-project#4606)
Fix: Support Alias Fields in MIN, MAX, FIRST, LAST, and TAKE Aggregations (opensearch-project#4621)
fix rename issue (opensearch-project#4670)
Fixes for `Multisearch` and `Append` command (opensearch-project#4512)
Fix asc/desc keyword behavior for sort command (opensearch-project#4651)
Fix] Fix unexpected shift of extraction for `rex` with nested capture groups in named groups  (opensearch-project#4641)
Fix CVE-2025-48924 (opensearch-project#4665)
Fix sub-fields accessing of generated structs (opensearch-project#4683)
Fix] Incorrect Field Index Mapping in AVG to SUM/COUNT Conversion (opensearch-project#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuancu yuancu yuancu approved these changes

@qianheng-aws qianheng-aws qianheng-aws approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar vamsimanohar is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger is a code owner

@RyanL1997 RyanL1997 Awaiting requested review from RyanL1997 RyanL1997 is a code owner

Assignees

No one assigned

Labels

backport 2.19-dev backport 3.3 bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] PPL parser rejects new join type=left syntax with ON clause due to incorrect ambiguity check

3 participants

@LantaoJin @yuancu @qianheng-aws