[Backport 2.19-dev] Support serializing & deserializing UDTs when pushing down scripts (#4245) #4626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#4245) * Support serializing & deserializing UDTs Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Update explain ITs Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Push down UDT types as string types for comparison operators Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Separate test cases and add an ignored IT Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Correct the handling of UDT in CalciteScriptEngine by substituting calcite's type factory with OpenSearchTypeFactory Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Fix deserialization for IP Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Remove testExplainPushDownScriptsContainingUDT in v2 Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Enable testLimitAfterAggregation in CalcitePPLAggregationIT Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Unit test serialize map and array types Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Fix deeper level deserialization of UDTs Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Add a yaml test for issue 4322 Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Add a test case for issue 4340 Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> * Remove redundant classes Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> --------- Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> (cherry picked from commit 69a718b)
songkant-aws
approved these changes
Oct 22, 2025
Contributor
|
My change also touches some files introduced by this PR. Will wait for its merge and resolve potential conflicts together. |
yuancu
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
LantaoJin
approved these changes
Oct 22, 2025
qianheng-aws
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #4245 to 2.19-dev
Commit Message
Support serializing & deserializing UDTs
Update explain ITs
Push down UDT types as string types for comparison operators
Separate test cases and add an ignored IT
Correct the handling of UDT in CalciteScriptEngine by substituting calcite's type factory with OpenSearchTypeFactory
Fix deserialization for IP
Remove testExplainPushDownScriptsContainingUDT in v2
Enable testLimitAfterAggregation in CalcitePPLAggregationIT
Unit test serialize map and array types
Fix deeper level deserialization of UDTs
Add a yaml test for issue 4322
Add a test case for issue 4340
Remove redundant classes
(cherry picked from commit 69a718b)
Description
[Describe what this change achieves]
Related Issues
Resolves #4063
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.