[Backport 2.19-dev] Implement one-batch lookahead for index enumerators (#4345) #4916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiddis
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
…ct#4345) Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
force-pushed
the
backport-4345-219-dev
branch
from
a1bbfd6 to
0bf4773
Compare
RyanL1997
previously approved these changes
Dec 8, 2025
Member
|
@Swiddis I still see the compile errors in CI |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
commented
Dec 9, 2025
| PrometheusStorageFactory prometheusStorageFactory = new PrometheusStorageFactory(settings); | ||
| HashMap<String, String> properties = new HashMap<>(); | ||
| properties.put("prometheus.uri", "https://test.com"); | ||
| properties.put("prometheus.uri", "https://opensearch.org"); |
Collaborator
Author
There was a problem hiding this comment.
test.com just dropped out of DNS, leading to URI validation failures. Quick fix.
LantaoJin
approved these changes
Dec 10, 2025
yuancu
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #4345 as there's no perf regression in OSB. In general, I'm confident that this helps it many query cases and doesn't overall hurt the general case.
Had to convert the Scanner away from record types because of JDK compatibility, should be no functionality diff.
Related Issues
N/A
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.