Skip to content

NO-JIRA: Fix (iss) must be a string type error#88

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
openshift-cloud-team:fix-typeerr
Apr 27, 2026
Merged

NO-JIRA: Fix (iss) must be a string type error#88
openshift-merge-bot[bot] merged 1 commit into
openshift-eng:mainfrom
openshift-cloud-team:fix-typeerr

Conversation

@RadekManak
Copy link
Copy Markdown
Contributor

This is a regression of #76. During the tooling overhaul the jwt library version was bumped causing the issue to regress.

This commit is quick fix to unblock rebasees. Casting the variable from int to str to pass the check.

I'll implement these changes to avoid similar regressions.

  1. Create E2E presubmit job that runs a full rebase with GitHub operations.
  2. Switch to better maintained PyGithub library NO-JIRA: Migrate from github3.py to PyGithub #71
  3. Setup type checker. Either https://github.com/astral-sh/ty (if it is ready) or Pyright.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@RadekManak: This pull request explicitly references no jira issue.

Details

In response to this:

This is a regression of #76. During the tooling overhaul the jwt library version was bumped causing the issue to regress.

This commit is quick fix to unblock rebasees. Casting the variable from int to str to pass the check.

I'll implement these changes to avoid similar regressions.

  1. Create E2E presubmit job that runs a full rebase with GitHub operations.
  2. Switch to better maintained PyGithub library NO-JIRA: Migrate from github3.py to PyGithub #71
  3. Setup type checker. Either https://github.com/astral-sh/ty (if it is ready) or Pyright.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from damdo and theobarberbany April 27, 2026 11:07
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: f858beec-9064-48ad-99d8-441b3ef4be9d

📥 Commits

Reviewing files that changed from the base of the PR and between ff9f99a and 4059570.

📒 Files selected for processing (1)
  • rebasebot/github.py

Walkthrough

The GitHub App authentication flow in _github_login_app now stringifies credentials.app_id before passing it to login_as_app and login_as_app_installation method calls, replacing direct usage of the credential value.

Changes

Cohort / File(s) Summary
GitHub App Authentication
rebasebot/github.py
Converts credentials.app_id to string for use in login_as_app and login_as_app_installation calls within _github_login_app function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 99a09a1 into openshift-eng:main Apr 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants