Skip to content

Conversation

@yingzhanredhat
Copy link
Contributor

@yingzhanredhat yingzhanredhat commented Dec 8, 2025

HYPERFLEET-295:
Exclude lint check for the generated file data/generated/openapi to resolve the failures https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/pr-logs/pull/openshift_release/72280/rehearse-72280-pull-ci-openshift-hyperfleet-hyperfleet-api-main-lint/1997938892216471552

Summary by CodeRabbit

  • Chores
    • Updated development build configuration to optimize code processing workflows.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci openshift-ci bot requested review from 86254860 and rh-amarin December 8, 2025 08:24
@openshift-ci openshift-ci bot added the approved label Dec 8, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025

Walkthrough

A new exclude directory pattern is added to the .golangci.yml configuration file to exclude generated OpenAPI code at data/generated/openapi from linting checks. This complements the existing exclusion of pkg/api/openapi and prevents lint analysis on auto-generated OpenAPI schema files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple configuration update with minimal scope
  • No logic changes or functional impact

Suggested labels

lgtm, approved

Suggested reviewers

  • crizzo71
  • jsell-rh

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: excluding lint checks for the generated file at data/generated/openapi, which matches the actual modification to .golangci.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8897da and 784205f.

📒 Files selected for processing (1)
  • .golangci.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: openshift-hyperfleet/hyperfleet-api PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-03T15:47:39.989Z
Learning: Applies to pkg/api/**/*.go : Use //go:embed directive to embed the OpenAPI specification at compile time from pkg/api/openapi/api/openapi.yaml
📚 Learning: 2025-12-03T15:47:39.989Z
Learnt from: CR
Repo: openshift-hyperfleet/hyperfleet-api PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-03T15:47:39.989Z
Learning: Applies to pkg/api/**/*.go : Use //go:embed directive to embed the OpenAPI specification at compile time from pkg/api/openapi/api/openapi.yaml

Applied to files:

  • .golangci.yml
📚 Learning: 2025-12-03T15:47:39.989Z
Learnt from: CR
Repo: openshift-hyperfleet/hyperfleet-api PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-03T15:47:39.989Z
Learning: Applies to pkg/api/openapi/**/*.go : Use make generate to regenerate Go models from openapi/openapi.yaml via openapi-generator-cli v7.16.0 in Podman

Applied to files:

  • .golangci.yml
🔇 Additional comments (1)
.golangci.yml (1)

5-5: Verify the generated directory path is correct.

The exclusion of data/generated/openapi follows the established pattern for generated code (consistent with pkg/api/openapi above). However, confirm that this path correctly reflects where your OpenAPI generation process outputs files. If the directory structure differs from what's shown here, the exclusion path may need adjustment.


Comment @coderabbitai help to get the list of available commands and usage tips.

@yasun1
Copy link
Contributor

yasun1 commented Dec 8, 2025

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yasun1, yingzhanredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [yasun1,yingzhanredhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bc5c73e into openshift-hyperfleet:main Dec 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants