-
Notifications
You must be signed in to change notification settings - Fork 12
Add linux/amd64 platform support for container builds #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux/amd64 platform support for container builds #17
Conversation
WalkthroughThe Makefile was updated to add the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
Makefile (2)
326-326: Architectural note: Enforces amd64 builds regardless of host platform.This change prevents native builds on non-amd64 systems (e.g., arm64 hosts will build amd64 images). If the project needs multi-architecture image support in the future, consider adding an environment variable to override the platform, such as
DOCKER_PLATFORM ?= linux/amd64.
49-70: Consider documenting platform enforcement in help text.The help text describes the
imageandimage-devtargets but doesn't mention that they now build forlinux/amd64. Consider adding a note for users, especially if this is a change in behavior.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
21248b8
into
openshift-hyperfleet:main
From #14, when building container images on Mac M1/M2/M3 (arm64 architecture), the images will now be explicitly built for linux/amd64 architecture, ensuring they work correctly when deployed to GKE clusters which run on linux/amd64.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.