Skip to content

Conversation

@yasun1
Copy link
Contributor

@yasun1 yasun1 commented Dec 11, 2025

From #14, when building container images on Mac M1/M2/M3 (arm64 architecture), the images will now be explicitly built for linux/amd64 architecture, ensuring they work correctly when deployed to GKE clusters which run on linux/amd64.

Summary by CodeRabbit

  • Chores
    • Updated container build configuration to explicitly target Linux platforms, ensuring consistent behavior across different build environments and improving compatibility guidance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025

Walkthrough

The Makefile was updated to add the --platform linux/amd64 flag to the Docker build commands in the image and image-dev targets and to include comments explaining platform requirements and alternatives for older Docker engines. No other build logic, error handling, or exported/public API declarations were changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding explicit linux/amd64 platform support to container builds in the Makefile, which aligns with the PR objectives of ensuring M1/M2/M3 Mac builds work correctly on linux/amd64 GKE clusters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29cf635 and 09af7ec.

📒 Files selected for processing (1)
  • Makefile (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Makefile

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
Makefile (2)

326-326: Architectural note: Enforces amd64 builds regardless of host platform.

This change prevents native builds on non-amd64 systems (e.g., arm64 hosts will build amd64 images). If the project needs multi-architecture image support in the future, consider adding an environment variable to override the platform, such as DOCKER_PLATFORM ?= linux/amd64.


49-70: Consider documenting platform enforcement in help text.

The help text describes the image and image-dev targets but doesn't mention that they now build for linux/amd64. Consider adding a note for users, especially if this is a change in behavior.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67e2059 and 29cf635.

📒 Files selected for processing (1)
  • Makefile (2 hunks)

@ciaranRoche
Copy link
Contributor

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 21248b8 into openshift-hyperfleet:main Dec 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants