Skip to content

Conversation

@rh-amarin
Copy link
Contributor

@rh-amarin rh-amarin commented Jan 21, 2026

https://issues.redhat.com/browse/HYPERFLEET-386

Depends on:

This PR aligns the API with the changes in the openshift-hyperfleet/architecture#79

  • Changes the usage of Phase for condition[Ready]
  • Changes the use of last_updated_time to use condition[Ready].LastUpdatedTime

Until hyperfleet-api changes include api spec v1.0.4, to tests the sentinel we need to specify

OPENAPI_SPEC_URL=https://raw.githubusercontent.com/rh-amarin/hyperfleet-api-spec/aefbd752a0c1a81b9213590d09ff7e614b6765b1/schemas/core/openapi.yaml

The change to Makefile is to be able to pass as environment variable a value for OPENAPI_SPEC_URL

Summary by CodeRabbit

  • Chores

    • Updated build configuration to allow environment overrides for OpenAPI specification sourcing.
    • Added internal directories to repository ignore list.
  • Refactor

    • Restructured resource status representation to use boolean readiness indicator with enhanced timing and lineage tracking.
    • Updated internal readiness evaluation logic and logging to reflect new status model.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci
Copy link

openshift-ci bot commented Jan 21, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

This PR restructures how resource status is managed throughout the application. It replaces a flat Phase string field with a Kubernetes-native condition model: a Ready boolean flag combined with a Conditions array containing structured condition objects with per-condition timing (LastUpdatedTime) and generation tracking (ObservedGeneration). The change propagates through API client normalization, decision-making logic, logging, and test fixtures. Additionally, .gitignore is updated to exclude .claude/ and the Makefile's OPENAPI_SPEC_URL is made overridable.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • rafabene
  • mbrudnoy
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the primary change: replacing Phase with Ready for decision logic, which is the main objective of this PR.
Docstring Coverage ✅ Passed Docstring coverage is 92.31% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@ciaranRoche ciaranRoche marked this pull request as ready for review January 22, 2026 12:40
@yasun1
Copy link
Contributor

yasun1 commented Jan 28, 2026

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yasun1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0f85b7d into openshift-hyperfleet:main Jan 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants