Skip to content

adding deprecated label to "legacy" sources#22

Merged
aliok merged 1 commit intoopenshift-knative:release-0.13.2from
matzew:SRVKE-420_deprecated_label
May 7, 2020
Merged

adding deprecated label to "legacy" sources#22
aliok merged 1 commit intoopenshift-knative:release-0.13.2from
matzew:SRVKE-420_deprecated_label

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented May 6, 2020

For SRVKE-420

Proposed Changes

  • adding deprecated labels to "legacy" source types

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@invincibleJai
Copy link
Copy Markdown

@matzew thanks for updating it, with this containerSource will get deprecated as we only have containersources.sources.eventing.knative.dev for containerSource and not containersources.sources.knative.dev

@matzew
Copy link
Copy Markdown
Member Author

matzew commented May 6, 2020

@invincibleJai on 0.13 there is ONLY the containersources.sources.eventing.knative.dev - that was marked as deprecated in fav. of the sinkbinding. (original idea around 0.13 release cut).

I wrote a migration guide:

However, there was lot's of noise, disagreement and bikeshed.

With the result that in 0.14 it got added back:

Note: It did "re-introduce" in containersources.sources.knative.dev API group

Copy link
Copy Markdown

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks , looks good :)

@aliok
Copy link
Copy Markdown
Member

aliok commented May 7, 2020

/lgtm

@aliok
Copy link
Copy Markdown
Member

aliok commented May 7, 2020

/approved

@aliok
Copy link
Copy Markdown
Member

aliok commented May 7, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok, matzew
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok aliok merged commit cd58d39 into openshift-knative:release-0.13.2 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants