Skip to content

[release-v1.11] Allow configuring whether to allow cross namespaces Brokers configuration references (#7455)#426

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.11from
pierDipi:cp-32d7dd83e76417f75daaa1e68c7aa2b89b14f218-v1.11
Dec 6, 2023
Merged

[release-v1.11] Allow configuring whether to allow cross namespaces Brokers configuration references (#7455)#426
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.11from
pierDipi:cp-32d7dd83e76417f75daaa1e68c7aa2b89b14f218-v1.11

Conversation

@pierDipi
Copy link
Copy Markdown
Member

Cherry-pick of knative@32d7dd8

…tion references (knative#7455)

* Allow configuring disallow cross namespaces Brokers configuration ref

Instead of always allowing to specify cross namespace configuration
references for Broker allow users to configure whether to disallow
such references as it might be problematic in multi tenant
environments.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Codegen

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Copy Markdown
Member Author

/cherry-pick release-v1.12

@openshift-cherrypick-robot
Copy link
Copy Markdown

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from creydr and matzew November 17, 2023 11:56
@pierDipi
Copy link
Copy Markdown
Member Author

/cc @creydr @Cali0707 @matzew

@openshift-ci openshift-ci Bot requested a review from Cali0707 November 17, 2023 11:59
@Cali0707
Copy link
Copy Markdown
Member

/retest-required

@matzew
Copy link
Copy Markdown
Member

matzew commented Nov 30, 2023

/test 413-test-reconciler-aws-ocp-413

1 similar comment
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Dec 4, 2023

/test 413-test-reconciler-aws-ocp-413

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Dec 6, 2023

/cc @matzew @Cali0707

Can you PTAL ?

@Cali0707
Copy link
Copy Markdown
Member

Cali0707 commented Dec 6, 2023

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot
Copy link
Copy Markdown

@pierDipi: new pull request created: #453

Details

In response to this:

/cherry-pick release-v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants