Skip to content

[release-v1.11] Don't use async handler (#7415)#515

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.11from
Cali0707:backport-imc-async-handler-v1.11
Feb 2, 2024
Merged

[release-v1.11] Don't use async handler (#7415)#515
openshift-merge-bot[bot] merged 1 commit into
openshift-knative:release-v1.11from
Cali0707:backport-imc-async-handler-v1.11

Conversation

@Cali0707
Copy link
Copy Markdown
Member

@Cali0707 Cali0707 commented Feb 1, 2024

Backport of knative@d964da3 so that the IMC is more dependable

/cc @pierDipi

* Don't use async handler

Signed-off-by: Calum Murray <cmurray@redhat.com>

* Fix Kn-Namespace header, potential race condition for sync receiver

Signed-off-by: Calum Murray <cmurray@redhat.com>

* try refactoring test

Signed-off-by: Calum Murray <cmurray@redhat.com>

* take 2 on test fix

Signed-off-by: Calum Murray <cmurray@redhat.com>

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
@openshift-ci openshift-ci Bot requested a review from pierDipi February 1, 2024 19:27
@Cali0707 Cali0707 changed the title Don't use async handler (#7415) [release-v1.11] Don't use async handler (#7415) Feb 1, 2024
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Feb 2, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 2303bba into openshift-knative:release-v1.11 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants