Skip to content

[release-v1.7] Use v1beta1 for Knative operator crd in tests#59

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.7from
openshift-cherrypick-robot:cherry-pick-9-to-release-v1.7
Dec 23, 2022
Merged

[release-v1.7] Use v1beta1 for Knative operator crd in tests#59
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.7from
openshift-cherrypick-robot:cherry-pick-9-to-release-v1.7

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #9

/assign creydr

@creydr
Copy link
Copy Markdown
Collaborator

creydr commented Dec 23, 2022

/retitle [release-v1.7] Use v1beta1 for Knative operator crd in tests

@openshift-ci openshift-ci Bot changed the title [release-v1.7] [RELEASE-1.6] Use v1beta1 for Knative operator crd in tests [release-v1.7] Use v1beta1 for Knative operator crd in tests Dec 23, 2022
@creydr
Copy link
Copy Markdown
Collaborator

creydr commented Dec 23, 2022

@skonto @matzew #9 didn't get ported to 1.7 and 1.8 and I guess this relates to the issues in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_eventing/58/pull-ci-openshift-knative-eventing-release-v1.7-411-test-e2e-aws-ocp-411/1606224317845082112:

...
        	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:"", RemainingItemCount:(*int64)(nil)}, Status:"Failure", Message:"the server could not find the requested resource", Reason:"NotFound", Details:(*v1.StatusDetails)(0xc00058ca80), Code:404}}

@creydr
Copy link
Copy Markdown
Collaborator

creydr commented Dec 23, 2022

/cherry-pick release-v1.8

@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

@creydr: once the present PR merges, I will cherry-pick it on top of release-v1.8 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

@creydr: new pull request created: #61

Details

In response to this:

/cherry-pick release-v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants